if browser.tabs.closeButtons == 3, you can't close tabs on pinstripe

RESOLVED FIXED in Firefox 2 beta2

Status

()

Firefox
Tabbed Browser
P2
normal
RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: (not reading, please use seth@sspitzer.org instead), Assigned: mano)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 beta2
All
Mac OS X
fixed1.8.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

if browser.tabs.closeButtons == 3, you can't close tabs on pinstripe.

we found this while investigating bug #342974

this works for windows and linux (at least, as of bug #343054) because the call to this.parentNode.parentNode.parentNode.parentNode.parentNode.removeCurrentTab() is in core toolkit xbl, but on mac (pinstripe) it is in the theme xbl, and script will not execute there.

a solution, suggested by asaf:

> Seth, we should really move this to tabbrowser.xml (as a <handler> in
> apseudo-private binding?) and expand it in the theme. Anyway, this belongs to
> bug 318168 or to a new bug (please CC me if so).
No longer depends on: 342974
The patch on bug 343628 addresses this issue.
Assignee: sspitzer → bugs.mano
Depends on: 343628
OS: All → Mac OS X 10.4
Priority: -- → P2
Hardware: PC → All
Target Milestone: --- → Firefox 2 alpha2
Target Milestone: Firefox 2 alpha2 → Firefox 2 beta2

Comment 2

12 years ago
I have not changed the browser.tabs.closeButtons config or even added it so this maybe a different bug but seems to happen after i've opened enough tabs to get the overflow kicked in. I close some of the tabs and then open some with ctrl+t and then it seems I can't close whatever tabs where left over from before I hit ctrl+t. Thats just the steps that I done just now and I think the other night when I first seen this but its not exact steps.

This is in the error console:

Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]
Source file: chrome://global/content/bindings/browser.xml

btw in the case of right now that I just seen this bug again, I can't close the first four tabs but I can close the last 5 I have open. 
Fixed on trunk (see bug 343628).
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.