343061 - if browser.tabs.closeButtons == 3, you can't close tabs on pinstripe

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

if browser.tabs.closeButtons == 3, you can't close tabs on pinstripe.

we found this while investigating bug #342974

this works for windows and linux (at least, as of bug #343054) because the call to this.parentNode.parentNode.parentNode.parentNode.parentNode.removeCurrentTab() is in core toolkit xbl, but on mac (pinstripe) it is in the theme xbl, and script will not execute there.

a solution, suggested by asaf:

> Seth, we should really move this to tabbrowser.xml (as a <handler> in
> apseudo-private binding?) and expand it in the theme. Anyway, this belongs to
> bug 318168 or to a new bug (please CC me if so).

Comment 1

[Asaf Romano (gone)]

The patch on bug 343628 addresses this issue.

Comment 2

[u88484]

I have not changed the browser.tabs.closeButtons config or even added it so this maybe a different bug but seems to happen after i've opened enough tabs to get the overflow kicked in. I close some of the tabs and then open some with ctrl+t and then it seems I can't close whatever tabs where left over from before I hit ctrl+t. Thats just the steps that I done just now and I think the other night when I first seen this but its not exact steps.

This is in the error console:

Error: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIDOMXULElement.boxObject]
Source file: chrome://global/content/bindings/browser.xml

btw in the case of right now that I just seen this bug again, I can't close the first four tabs but I can close the last 5 I have open. 

Comment 3

[Asaf Romano (gone)]

Fixed on trunk (see bug 343628).