Correct margins in history preference pane

VERIFIED FIXED in Camino1.5

Status

--
minor
VERIFIED FIXED
13 years ago
13 years ago

People

(Reporter: froodian, Assigned: froodian)

Tracking

({verified1.8.1})

unspecified
Camino1.5
PowerPC
macOS
verified1.8.1

Details

Attachments

(2 attachments, 6 obsolete attachments)

(Assignee)

Description

13 years ago
This is part of preference pane cleanup. (see bug 325880)
(Assignee)

Comment 1

13 years ago
Posted file New History.nib (obsolete) —
Attachment #227496 - Flags: review?(alqahira)
(Assignee)

Comment 2

13 years ago
Posted image Screenshot (obsolete) —
Comment on attachment 227496 [details]
New History.nib

There's extra space on the right, due to the extra length of the text boxes again.
Attachment #227496 - Flags: review?(alqahira) → review-
(Assignee)

Comment 4

13 years ago
Comment on attachment 227496 [details]
New History.nib

Are you sure?  Both hint text boxes are pulled exactly to 20px from the end...
Attachment #227496 - Flags: review- → review?(alqahira)
Yes, but both have 15-20px of blank space between the last character and the edge of the box, so it looks like 35-40px.
(Assignee)

Comment 6

13 years ago
Posted file Fixes centering (obsolete) —
yeah, you're right.  sorry about that. :p
Attachment #227496 - Attachment is obsolete: true
Attachment #227523 - Flags: review?(alqahira)
Attachment #227496 - Flags: review?(alqahira)
(Assignee)

Comment 7

13 years ago
Posted image Screenshot (obsolete) —
Attachment #227497 - Attachment is obsolete: true
Comment on attachment 227523 [details]
Fixes centering

The bottom rectangle still is longer than its text, which makes the right side look bigger.  It's certainly better.

Shouldn't we be setting first responder on the text field for when the "force focus highlight on first item" bug is fixed?
Attachment #227523 - Flags: review?(alqahira) → review-
(Assignee)

Comment 9

13 years ago
Posted file Centers more betterer (obsolete) —
Also fixes initialFirstResponder.  Thanks for catching that.
Attachment #227523 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #227645 - Flags: review?(alqahira)
(Assignee)

Comment 10

13 years ago
Posted image Screenshot (obsolete) —
Attachment #227524 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #227645 - Flags: superreview?(mikepinkerton)
i think the vertical compression makes things too busy and hard to separate the differnt prefs visually. Agreement?
(Assignee)

Comment 12

13 years ago
Attachment #227645 - Attachment is obsolete: true
Attachment #227645 - Flags: superreview?(mikepinkerton)
(Assignee)

Comment 13

13 years ago
Posted image Screenshot
Attachment #227646 - Attachment is obsolete: true
(Assignee)

Updated

13 years ago
Attachment #230123 - Flags: superreview?(mikepinkerton)
Comment on attachment 230123 [details]
Expands space slightly

sr=pink
Attachment #230123 - Flags: superreview?(mikepinkerton) → superreview+
Whiteboard: [needs checkin]

Comment 15

13 years ago
Fixed trunk and branch.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [needs checkin]
(Assignee)

Updated

13 years ago
Status: RESOLVED → VERIFIED
Keywords: verified1.8.1
(Assignee)

Updated

13 years ago
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.