343112 - @Bugzilla::Config::parampanels is only defined if something calls _load_params

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Max Kanat-Alexander]

In bug 342869 LpSolit noticed that @parampanels isn't defined if nothing calls _load_params.

So, instead, we should just have a subroutine in Bugzilla::Config that returns @parampanels. (Which is better anyway, because then we get rid of that package-global variable.)

Comment 1

[Max Kanat-Alexander]

Attachment: v1

Okay, this is a nice clean fix for the problem. We replace @parampanels with a subroutine called param_panels, which works nicely. This will slightly bitrot my patch in bug 342869, but that's okay--the bitrot will be easy to fix.

Comment 2

[Frédéric Buclin]

Comment on attachment 227542 [details] [diff] [review]
v1

Looks good except your patch is bitrotten due to the checkin of bug 342121. So I couldn't test it.

Comment 3

[Max Kanat-Alexander]

Attachment: v1.1

Ah, okay! I fixed the bitrot. :-)

Comment 4

[Max Kanat-Alexander]

Attachment: v1.2

I noticed that I'd added Bugzilla::Constants in twice to Bugzilla::Config.

Comment 5

[Frédéric Buclin]

Comment on attachment 227822 [details] [diff] [review]
v1.2

works fine. r=LpSolit

Comment 6

[Max Kanat-Alexander]

Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in Bugzilla/Config.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Config.pm,v  <--  Config.pm
new revision: 1.62; previous revision: 1.61
done