343247 - Undefined entity error in 'About Sunbird' dialog, credits dialog broken

Status: VERIFIED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060628 Sunbird/0.3a2+

Undefined entity error in 'About Sunbird' dialog, credits dialog broken
Most probably caused by check in for Bug 328563.

Steps to Reproduce:
1. Start Sunbird
2. Select 'Help -> About Mozilla Sunbird'
3. In about dialog select 'Credits'

  Error: undefined entity
  Source File: 
  jar:file:///D:/sb/chrome/calendar.jar!/content/calendar/credits.xhtml
  Line: 219, Column: 11
  Source Code:
            &license.and;

  Error: cb has no properties
  Source File: chrome://calendar/content/credits.xhtml
  Line: 134

Comment 1

[Stefan Sitter [:ssitter]]

Seems they forgot Sunbird when solving Bug 322000. We should update our credits.xhtml to use the same content as:
http://lxr.mozilla.org/mozilla/source/browser/base/content/credits.xhtml
or http://lxr.mozilla.org/mozilla/source/mail/base/content/credits.xhtml

Comment 2

[Matthew (lilmatt) Willis]

Taking this.

Comment 3

[Matthew (lilmatt) Willis]

We can't just update to the Ff/Tb new content, as we don't have a browser to display about:license in.

I'm attempting to fix this by simply adding the entity that they removed out from under us (license.and).

Comment 4

[Matthew (lilmatt) Willis]

Attachment: add missing entity

Comment 5

[Joey Minta]

Comment on attachment 227988 [details] [diff] [review]
add missing entity

r=jminta as long as there's a follow-up for syncing our license stuff with everyone else's.  TB doesn't really have a browser, so we should probably follow them as a model.

Comment 6

[Matthew (lilmatt) Willis]

(In reply to comment #5)
> r=jminta as long as there's a follow-up for syncing our license stuff with
> everyone else's.

Bug 343544 created for that.

Patch checked in on MOZILLA_1_8_BRANCH and trunk

-> FIXED

Comment 7

[Damian Szczepanik]

verified with
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060823 Calendar/0.3a2+

Comment 8

[Matthew (lilmatt) Willis]

-> VERIFIED