Closed Bug 343253 Opened 13 years ago Closed 13 years ago
Improve unknown cert issuer dialog
This is a split off of the discussion started in bug 342862. I will post a patch that implements the suggestions from bug 342862 comment 16, and a screenshot that shows the changes.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.9alpha
The patch: 1- Moves the "Examine certificate..." button to a dialog button position 2- Changes it's label to "View Certificate..." 3- Removes the redundant third option in the radio button group 4- Changes the dialog's default button to "Cancel" The button position is different on Linux/Mac than on Windows, obeying the platform guidelines for where the Cancel/Confirm/"extra" buttons should be. I think there is general agreement that 4 is a good idea, I don't think the same could be said of the other three changes. Thoughts?
If you're going to remove that radiobutton it might be worth changing the other two to use values rather than doing comparisons on ids.
Comment on attachment 229573 [details] [diff] [review] updated patch >-#ifndef XP_MACOSX >- document.documentElement.getButton("accept").focus(); >-#endif You forgot to remove the * from the jar.mn line. > <dialog id="newServerDialog" >+ spacerflex="1" > buttons="accept,cancel,help" ,extra2 sr=me with these fixed.
Attachment #229573 - Flags: superreview?(neil) → superreview+
Comment on attachment 229650 [details] [diff] [review] addressing Neil's comments We should also get a bug on file for changing the horrid, horrid text that's above these lovely changes.
Attachment #229650 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 229650 [details] [diff] [review] addressing Neil's comments Thanks for the patch. r=kengert
Attachment #229650 - Flags: review?(kengert) → review+
Whiteboard: [patch-r?] → [checkin needed]
mozilla/security/manager/locales/en-US/chrome/pippki/newserver.dtd 1.2 mozilla/security/manager/pki/resources/jar.mn 1.52 mozilla/security/manager/pki/resources/content/newserver.xul 1.26 mozilla/security/manager/pki/resources/content/newserver.js 1.24 mozilla/extensions/help/resources/content/helpSecurityOverlay.xul 1.2
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
You need to log in before you can comment on or make changes to this bug.