343264 - I'm prompted to save a password that password manager filled in

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In trunk builds, I've been prompted to save passwords that password manager filled in.  This is a recent regression in the past week or so, probably from Michael Wu's password manager changes.

Steps to reproduce:
 1. set up Firefox so it remembers your password (e.g., tell it to remember if it doesn't already) on http://bugzilla.mozilla.org/
 2. load http://bugzilla.mozilla.org
 3. Click "<a>Log Out</a> [e-mail]" in the footer if you're logged in
 4. Click "<a>Log In</a>" in the footer
 5. click the "Log In" button

Expected results:
 4. password filled in to form
 5. form submits without prompt

Actual results:
 4. [same as expected]
 5. Dialog pops up: Confirm: Do you want Firefox to remember this password?

Comment 1

[Ria Klaassen (not reading all bugmail)]

This is Bug 343182 I think.

Comment 2

[Michael Wu [:mwu]]

(In reply to comment #1)
> This is Bug 343182 I think.
> 
This is another regression from the bug 257781, though the fix will probably be the same as for bug 343182. I think certain assumptions that the password manager makes about the form are incorrect when it is notified earlier.

Comment 3

[Michael Wu [:mwu]]

Nevermind, this appears to be a regression from bug 221634.

Comment 4

[Michael Wu [:mwu]]

Attachment: Avoid leak, properly load passwords

Apparently, it's a bad idea to preinitialize the password manager during app-startup, but it's perfectly okay during profile-after-change. This fixes both this bug (by allowing the passwords to be properly loaded so the password manager doesn't get confused) and bug 343022.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Blocks beta2, but we'll take a reviewed and baked patch for beta 1 if we can get it.

Comment 6

[Ria Klaassen (not reading all bugmail)]

The login page needs to be reloaded before the autocomplete list shows up (e.g. on Gmail and on Freemail). 
Does the patch also contain a fix for this?

Comment 7

[Ria Klaassen (not reading all bugmail)]

(In reply to comment #6)
>
That is a regression from Bug 343022; the leak.

Comment 8

[Ria Klaassen (not reading all bugmail)]

Hm, I did not change it to assigned, sorry. Must have gone something wrong.

Comment 9

[Mike Connor [:mconnor]]

Taking off the list, since the patch that caused this never landed on branch.  If it does, but 221634 has the rollup with this fix.