Closed
Bug 343266
Opened 19 years ago
Closed 19 years ago
only try a table update on http status 200
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
RESOLVED
FIXED
Firefox 2 beta2
People
(Reporter: tony, Assigned: tony)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
1.58 KB,
patch
|
darin.moz
:
review+
beltzner
:
approval1.8.1+
|
Details | Diff | Splinter Review |
The url classifier stream updater doesn't check the http status of the update request. It should verify status 200 before trying to update (not a big deal since it ignores malformed lines).
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #229007 -
Flags: review?(darin)
|
|
||
Updated•19 years ago
|
Attachment #229007 -
Flags: review?(darin) → review+
|
|
Assignee | |
Updated•19 years ago
|
Flags: blocking-firefox2?
|
|
||
Comment 3•19 years ago
|
||
Tony, did you intentionally comment out the LOG call? Not clear how that's related here.
Status: NEW → ASSIGNED
Flags: blocking-firefox2? → blocking-firefox2+
|
|
Assignee | |
Comment 4•19 years ago
|
||
(In reply to comment #3)
> Tony, did you intentionally comment out the LOG call? Not clear how that's
> related here.
Yes, it was really verbose, even for debugging.
|
|
Assignee | |
Updated•19 years ago
|
Attachment #229007 -
Flags: approval1.8.1?
|
||
Comment 5•19 years ago
|
||
Comment on attachment 229007 [details] [diff] [review]
v1: check RequestSucceeded before updateing
a=drivers, please land on the branch.
Attachment #229007 -
Flags: approval1.8.1? → approval1.8.1+
|
|
Assignee | |
Comment 6•19 years ago
|
||
on branch
|
||
Updated•11 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•