All users were logged out of Bugzilla on October 13th, 2018

only try a table update on http status 200

RESOLVED FIXED in Firefox 2 beta2

Status

()

RESOLVED FIXED
13 years ago
4 years ago

People

(Reporter: tony, Assigned: tony)

Tracking

({fixed1.8.1})

Trunk
Firefox 2 beta2
fixed1.8.1
Points:
---
Bug Flags:
blocking-firefox2 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
The url classifier stream updater doesn't check the http status of the update request.  It should verify status 200 before trying to update (not a big deal since it ignores malformed lines).
(Assignee)

Comment 1

12 years ago
Created attachment 229007 [details] [diff] [review]
v1: check RequestSucceeded before updateing
Attachment #229007 - Flags: review?(darin)

Updated

12 years ago
Attachment #229007 - Flags: review?(darin) → review+
(Assignee)

Comment 2

12 years ago
on trunk
Target Milestone: --- → Firefox 2 beta2
(Assignee)

Updated

12 years ago
Flags: blocking-firefox2?
Tony, did you intentionally comment out the LOG call?  Not clear how that's related here.
Status: NEW → ASSIGNED
Flags: blocking-firefox2? → blocking-firefox2+
(Assignee)

Comment 4

12 years ago
(In reply to comment #3)
> Tony, did you intentionally comment out the LOG call?  Not clear how that's
> related here.

Yes, it was really verbose, even for debugging.
(Assignee)

Updated

12 years ago
Attachment #229007 - Flags: approval1.8.1?
Comment on attachment 229007 [details] [diff] [review]
v1: check RequestSucceeded before updateing

a=drivers, please land on the branch.
Attachment #229007 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Comment 6

12 years ago
on branch
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Component: Phishing Protection → Phishing Protection
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.