343285 - Copy should be disabled for password fields

Status: RESOLVED FIXED

(Camino Graveyard :: Toolbars & Menus, defect)

Description

[Peter Jaros (:peeja)]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060629 Camino/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8.1a3) Gecko/20060629 Camino/1.0+

With text selected in a password field, copy should be disabled.  Currently, a password cannot be copied out of the field, but the state of the Copy command should reflect this.

Reproducible: Always

Steps to Reproduce:
1. Enter text into a password field.
2. Select text.
3. Copy.
4. Optionally, paste text somewhere to examine it.

Actual Results:  
"*******" is copied to the pasteboard.

Expected Results:  
Copy should be unavailable, since it performs no useful function.

This might be filed under the wrong component, as it may be considered a menu issue, not a forms issue.

Comment 1

[Trevor Johns]

I believe this is a duplicate of bug 217729 over in core.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think we might be able to fix this in Camino; I think we have some way of knowing what type of field we're in.

50/50 on which component, but there are other validation bugs in Menus, so -->

Comment 3

[Chris Lawson (gone)]

Confirming. If it turns out this has to go to Core, we can do that later, but let's see if we can fix it on our end (especially as it seems the Core bug has no hope of being fixed soon).

Comment 4

[Stuart Morgan]

Attachment: fix

Comment 5

[Mark Mentovai]

Comment on attachment 289174 [details] [diff] [review]
fix

>Index: src/embedding/CHBrowserView.mm

>+// -isPasswordFieldFocused
>+//
>+// Returs YES if a password field in the content area has focus.
>+//

Add a note here that we have to do this check ourselves because core doesn't, and that if bug 217729 is ever fixed, we'll possibly be able to get rid of this rely on core doing the right thing.  Maybe also file (or get someone else to file) a bug dependent on 217729 to take this out.

>+    nsAutoString type;
>+    input->GetType(type);
>+    if (type == NS_LITERAL_STRING("password"))

I'd prefer |if (type.Equals(NS_LITERAL_STRING("password")))|.

Comment 6

[Stuart Morgan]

Landed on trunk and MOZILLA_1_8_BRANCH with the above changes.