process_bug.cgi calls certain constants as global subroutines

RESOLVED FIXED in Bugzilla 3.0

Status

()

defect
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: mkanat, Assigned: mkanat)

Tracking

2.23
Bugzilla 3.0
Dependency tree / graph
Bug Flags:
approval +

Details

Attachments

(1 attachment)

We noticed this in another bug, but I didn't think it was a problem.

Anyhow, there's no real "main" package in mod_perl, so you can't call anything from "main." process_bug is the only script left that does this, as far as I can tell, with subroutines.

There might still be a few scripts that attempt to use variables from $main::, but we can handle those later.
Posted patch v1Splinter Review
Trivial fix.
Attachment #227825 - Flags: review?(LpSolit)
Status: NEW → ASSIGNED
Comment on attachment 227825 [details] [diff] [review]
v1

r=LpSolit
Attachment #227825 - Flags: review?(LpSolit) → review+
Flags: approval?
Flags: approval? → approval+
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.331; previous revision: 1.330
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.