Last Comment Bug 343346 - [mod_perl] Cache Bugzilla->template per-process to improve performance
: [mod_perl] Cache Bugzilla->template per-process to improve performance
Status: NEW
:
Product: Bugzilla
Classification: Server Software
Component: Bugzilla-General (show other bugs)
: 2.23
: All All
: P4 enhancement (vote)
: ---
Assigned To: Nobody; OK to take it and work on it
: default-qa
:
Mentors:
: 979413 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-01 12:38 PDT by Max Kanat-Alexander
Modified: 2014-03-04 21:20 PST (History)
5 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments

Description Max Kanat-Alexander 2006-07-01 12:38:39 PDT
Right now we're creating a new Bugzilla->template on each request.

Instead, it might be better to just keep re-using the Template object over and over as long as we're in the same process. This would also let us take advantage of the Template-Toolkit cache, where it's already loaded the template code into memory and doesn't even have to read the disk for the data.
Comment 1 Michael Thomas (Mockodin) 2009-10-14 12:46:49 PDT
mkanat what is involved with this request?
Comment 2 Max Kanat-Alexander 2009-10-14 17:02:07 PDT
(In reply to comment #1)
> mkanat what is involved with this request?

  Discovering a working way to cache items per-process under mod_perl.
Comment 3 Max Kanat-Alexander 2009-10-14 17:02:27 PDT
Oh, and then making sure that Template-Toolkit doesn't leak like crazy across requests.
Comment 4 Frédéric Buclin 2012-08-31 16:25:19 PDT
glob: didn't you fix that in bug 778631?
Comment 5 Byron Jones ‹:glob› [PTO until 2017-01-09] 2012-09-02 20:50:17 PDT
(In reply to Frédéric Buclin from comment #4)
> glob: didn't you fix that in bug 778631?

bug 778631 implements a single Template::Provider object per process, which is different from a Bugzilla::Template object per process.  there may be additional gains by caching the main template object, as this is the recommended mod_perl deployment strategy for template-toolkit.
Comment 6 Byron Jones ‹:glob› [PTO until 2017-01-09] 2014-03-04 21:20:01 PST
*** Bug 979413 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.