343346 - [mod_perl] Cache Bugzilla->template per-process to improve performance

Status: NEW

(Bugzilla :: Bugzilla-General, enhancement, P4)

Description

[Max Kanat-Alexander]

Right now we're creating a new Bugzilla->template on each request.

Instead, it might be better to just keep re-using the Template object over and over as long as we're in the same process. This would also let us take advantage of the Template-Toolkit cache, where it's already loaded the template code into memory and doesn't even have to read the disk for the data.

Comment 1

[Michael Thomas (Mockodin)]

mkanat what is involved with this request?

Comment 2

[Max Kanat-Alexander]

(In reply to comment #1)
> mkanat what is involved with this request?

  Discovering a working way to cache items per-process under mod_perl.

Comment 3

[Max Kanat-Alexander]

Oh, and then making sure that Template-Toolkit doesn't leak like crazy across requests.

Comment 4

[Frédéric Buclin]

glob: didn't you fix that in bug 778631?

Comment 5

[:glob ✱]

(In reply to Frédéric Buclin from comment #4)
> glob: didn't you fix that in bug 778631?

bug 778631 implements a single Template::Provider object per process, which is different from a Bugzilla::Template object per process.  there may be additional gains by caching the main template object, as this is the recommended mod_perl deployment strategy for template-toolkit.