343383 - cookies don't work in 'suiterunner' seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Denis Misiurca]

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.5; Linux; X11; i686; ru) KHTML/3.5.2 (like Gecko) Kubuntu 6.04 Dapper
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060702 /

I compiled seamonkey from cvs (build id=2006070200) and cannot login to any site. tried to change cookie settings, but no effect.

Reproducible: Always

Steps to Reproduce:
1. go to gmail
2. try to login

Actual Results:  
Can't login. Gmail says that cookies are disabled

Expected Results:  
Successful login

From about:buildconfig
gcc version 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubuntu9)

Compiler flags
gcc  	-Wall -W -Wno-unused -Wpointer-arith -Wcast-align -Wno-long-long -pedantic -pthread -pipe
c++ 	-fno-rtti -fno-exceptions -Wall -Wconversion -Wpointer-arith -Wcast-align -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy -Wno-non-virtual-dtor -Wno-long-long -pedantic -fshort-wchar -pthread -pipe

Configure arguments
--enable-optimize --disable-debug --enable-default-toolkit=cairo-gtk2 --enable-glitz --enable-xft --disable-static --enable-shared --disable-tests --enable-canvas --enable-svg --enable-strip --enable-elf-dynstr-gc --enable-application=suite --enable-static-mail

Comment 1

[Frank Wein [:mcsmurf]]

Confirming with a suiterunner trunk build. Another test site for cookies is for example http://www.tempesttech.com/cookies/cookietest1.asp, in normal SeaMonkey trunk builds it works, in suiterunner it does not.

Comment 2

[Andrew Schultz]

For some reason, suiterunner is using nsMsgContentPolicy as its nsICookiePermission service.  It's building extensions/cookie/ but not using it.  How does it decide which one to use?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> For some reason, suiterunner is using nsMsgContentPolicy as its
> nsICookiePermission service.  It's building extensions/cookie/ but not using
> it.  How does it decide which one to use?

This is probably something to do with MOZ_XUL_APPs doing things (registering) slightly differently. It looks like nsMsgContentPolicy exists in "standard" SeaMonkey as well so we should be able to use the right one. I'll take a look at it later, I wondered why we were getting a lot of mailnews warnings...

Comment 4

[Mark Banner (:standard8)]

Attachment: nsMsgCookiePolicy is only required for thunderbird.

nsMsgCookiePolicy is only required for thunderbird as it doesn't have access to the same things that suite does (it also caused a duplicate registered contract id, so the extensions/cookie one was being overwritten by the nsMsgCookiePolicy one).

This also fixes the nsMsgUtils.cpp warnings seen when using the browser part of suiterunner.

I've tested it with the link in comment 2 (thanks Frank) and it seems to work ok.

Comment 5

[[e-mail]]

Sorry for stomping on the sr+, I'm not sure how I managed that :-/

Comment 6

[Ian Neal]

Comment on attachment 227952 [details] [diff] [review]
nsMsgCookiePolicy is only required for thunderbird.

Setting sr+ from bienvenu

Comment 7

[Mark Banner (:standard8)]

Patch checked in.