Closed
Bug 343432
Opened 18 years ago
Closed 18 years ago
Remove Bugzilla::Flag::get() and implement real flag objects
Categories
(Bugzilla :: Attachments & Requests, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file, 1 obsolete file)
|
19.66 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
In order to keep patches small, I split bug 304699 and open this bug to implement real flag objects. Bugzilla::Flag::get() and Bugzilla::Flag::perlify_record() disappear in favor of flag objects and methods. I haven't updated POD as I don't think the current code will be the final one. Next step will be to implement real flagtype objects.
|
Assignee | |
Comment 1•18 years ago
|
||
Attachment #227902 -
Flags: review?(myk)
|
|
Assignee | |
Updated•18 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•18 years ago
|
||
Bugzilla::Flag now uses Bugzilla::Object to simplify flag object creation.
Attachment #227902 -
Attachment is obsolete: true
Attachment #228354 -
Flags: review?(myk)
Attachment #227902 -
Flags: review?(myk)
|
||
Comment 3•18 years ago
|
||
Comment on attachment 228354 [details] [diff] [review] patch, v1.1 Looks good, r=myk
Attachment #228354 -
Flags: review?(myk) → review+
|
|
||
Updated•18 years ago
|
Flags: approval+
|
|
Assignee | |
Comment 4•18 years ago
|
||
Checking in Bugzilla/Flag.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/Flag.pm,v <-- Flag.pm new revision: 1.69; previous revision: 1.68 done Checking in Bugzilla/User.pm; /cvsroot/mozilla/webtools/bugzilla/Bugzilla/User.pm,v <-- User.pm new revision: 1.117; previous revision: 1.116 done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•