343604 - Empty applet tag fails to load the Java plugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Martijn Wargers (dead)]

When using <applet></applet>, it used to load the Java plugin in Mozilla. That's not happening anymore in current trunk build.
This worked in a 2005-10-08 build, but fails in a 2005-10-11 build.
This seems like a regression from bug 311674.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Internet Explorer and Opera both load the Java plugin.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

is this even a bug?

anyway... the code is at http://lxr.mozilla.org/seamonkey/source/content/html/content/src/nsHTMLSharedObjectElement.cpp#397 (with an outdated comment), so just removing the if and always doing the else block should fix this, I think.

Comment 3

[Martijn Wargers (dead)]

I guess this is not really a bug, but perhaps a compatibility issue (although loading broken Java applets isn't that useful anyway).

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

this ought to fix it, I'll test it once I have a build

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 228194 [details] [diff] [review]
patch

OK, tested and works.

This patch is good even if this bug isn't really a bug, because it simplifies the code.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 228194 [details] [diff] [review]
patch

Sure.  Sounds good.

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in content/html/content/src/nsHTMLSharedObjectElement.cpp;
/cvsroot/mozilla/content/html/content/src/nsHTMLSharedObjectElement.cpp,v  <--  nsHTMLSharedObjectElement.cpp
new revision: 1.81; previous revision: 1.80
done