343702 - editflagtypes.cgi: Argument "" isn't numeric in numeric gt (>) at template/en/default/request/email.txt.tmpl line 155.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

When notifying a user about a flag being changed, request/email.txt.tmpl is called, which contains:

[% IF Bugzilla.cgi.param("comment").length > 0 %]

When changing the inclusion and exclusion lists in editflagtypes.cgi, no comment field exists and the following error is generated in the web server log:

editflagtypes.cgi: Argument "" isn't numeric in numeric gt (>) at template/en/default/request/email.txt.tmpl line 155.

So first have to check whether this field exists before looking at its length.

This problem was introduced during deFORMication in 2.20, see bug 225818.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Another one-liner.

Comment 2

[Frédéric Buclin]

tip:

Checking in template/en/default/request/email.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/email.txt.tmpl,v  <--  email.txt.tmpl
new revision: 1.13; previous revision: 1.12
done

2.22:

Checking in template/en/default/request/email.txt.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/request/email.txt.tmpl,v  <--  email.txt.tmpl
new revision: 1.11.2.1; previous revision: 1.11
done