343784 - home page not migrated

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[juan becerra [:juanb]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/2006070513 Firefox/1.5.0.5

Home Page is not migrated as part of the profile migration.

To recreate:
1. Remove your Firefox folder from the Application Support/Mozilla directory
2. Use Mozilla 1.7.x (1.7.13 used) and add some bookmarks, save some passwords, etc..., and set your home page to something like www.slashdot.org
3. Launch Firefox and when the migration wizard comes up choose to migrate data from Mozilla, including the dialog that prompts to set the Home Page to the one used Mozilla
4. After FF starts click on the Home Page icon to go to the home page

Expected: You should be redirected to the Home Page set for Mozilla which we migrated, www.slashdot.org for example.

Actual: The Firefox Start page with the google search bar appears

Comment 1

[Tracy Walker [:tracy]]

this worked in 1.5 and 1.5.0.1.  It has been broken since 1.5.0.2 specifically broken between 20060220 and 20060222.
cc'ing masayuki.  checkin during that time frame is likely suspect.

Comment 2

[Adam Guthrie]

Check-in range: 
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=MOZILLA_1_8_0_BRANCH&branchtype=match&dir=mozilla%2Fbrowser%2Fcomponents%2Fmigration&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2006-02-20&maxdate=2006-02-22&cvsroot=%2Fcvsroot

Tracy forgot to mention it, but the bug that regressed this is bug 327303.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

http://lxr.mozilla.org/mozilla/source/browser/components/migration/content/migration.js#465

On the case is "Migration:Ended" in observe, |this._newHomePage| has correct value. But it's not saved if from Seamonkey. Why?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv1.0

I should not have removed the code of reading/saving by prefService.
But we need to save prefs before reset for others.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 228405 [details] [diff] [review]
Patch rv1.0

Sorry. It's very risky. The saving may destroy original(other browser's) profile.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch rv2.0

This is better.

Comment 7

[Daniel Veditz [:dveditz]]

Need a reviewed patch landed on trunk and 1.8-branch before we can consider non-security fixes for the 1.8.0 branch. Not making 1.8.0.7

Comment 8

[juan becerra [:juanb]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1

This also has the same problem.

Comment 9

[Mike Connor [:mconnor]]

Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

ok, that looks good, thanks Masayuki!

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to trunk.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

Let's go to 1.8.1 branch.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in to 1.8.1 branch too.