Closed Bug 343784 Opened 16 years ago Closed 15 years ago

home page not migrated

Categories

(Firefox :: Migration, defect)

1.5.0.x Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 2

People

(Reporter: jbecerra, Assigned: masayuki)

References

Details

(Keywords: fixed1.8.1, regression)

Attachments

(1 file, 1 obsolete file)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.5) Gecko/2006070513 Firefox/1.5.0.5

Home Page is not migrated as part of the profile migration.

To recreate:
1. Remove your Firefox folder from the Application Support/Mozilla directory
2. Use Mozilla 1.7.x (1.7.13 used) and add some bookmarks, save some passwords, etc..., and set your home page to something like www.slashdot.org
3. Launch Firefox and when the migration wizard comes up choose to migrate data from Mozilla, including the dialog that prompts to set the Home Page to the one used Mozilla
4. After FF starts click on the Home Page icon to go to the home page

Expected: You should be redirected to the Home Page set for Mozilla which we migrated, www.slashdot.org for example.

Actual: The Firefox Start page with the google search bar appears
this worked in 1.5 and 1.5.0.1.  It has been broken since 1.5.0.2 specifically broken between 20060220 and 20060222.
cc'ing masayuki.  checkin during that time frame is likely suspect.
Keywords: regression
Flags: blocking1.8.0.6?
http://lxr.mozilla.org/mozilla/source/browser/components/migration/content/migration.js#465

On the case is "Migration:Ended" in observe, |this._newHomePage| has correct value. But it's not saved if from Seamonkey. Why?
Attached patch Patch rv1.0 (obsolete) — Splinter Review
I should not have removed the code of reading/saving by prefService.
But we need to save prefs before reset for others.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Attachment #228405 - Flags: review?(mconnor)
Comment on attachment 228405 [details] [diff] [review]
Patch rv1.0

Sorry. It's very risky. The saving may destroy original(other browser's) profile.
Attachment #228405 - Flags: review?(mconnor) → review-
Attached patch Patch rv2.0Splinter Review
This is better.
Attachment #228405 - Attachment is obsolete: true
Attachment #228428 - Flags: review?(mconnor)
Need a reviewed patch landed on trunk and 1.8-branch before we can consider non-security fixes for the 1.8.0 branch. Not making 1.8.0.7
Flags: blocking1.8.0.7? → blocking1.8.0.7-
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060816 BonEcho/2.0b1

This also has the same problem.
Flags: blocking-firefox2+
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

ok, that looks good, thanks Masayuki!
Attachment #228428 - Flags: review?(mconnor) → review+
checked-in to trunk.
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

Let's go to 1.8.1 branch.
Attachment #228428 - Flags: approval1.8.1?
Comment on attachment 228428 [details] [diff] [review]
Patch rv2.0

a=beltzner on behalf of drivers, please land on MOZILLA_1_8_BRANCH
Attachment #228428 - Flags: approval1.8.1? → approval1.8.1+
checked-in to 1.8.1 branch too.
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.