Closed Bug 343791 Opened 18 years ago Closed 18 years ago

Safebrowsing not working in trunk

Categories

(Toolkit :: Safe Browsing, defect)

Product:
Toolkit
Component:
Safe Browsing
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 341950

People

(Reporter: ria.klaassen, Unassigned)

References

Details

Today I saw a weird error in the JSConsole:

Error: junk after document element
Source File: chrome://browser/content/safebrowsing/report-phishing-overlay.xul
Line: 59, Column: 1
Source Code:
<?xml version="1.0"?>

So I tried out if there was something wrong with safebrowsing and it did not work indeed. The error was visible for the first time between 1.9a1_2006070516 and 1.9a1_2006070522.

But safebrowsing itself failed earlier: between 1.9a1_2006061721 and 1.9a1_2006061810. 

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-17+20%3A00&maxdate=2006-06-18+11%3A00

I tried also branch but there it works.
Also, I should point out that the canvas overlay isn't working on trunk.  See bug 341950.  It may be the case that we need to do the dimmed overlay differently on trunk and on branch, but that's a low priority right now.
This is fixed by the patch in bug 337484, I believe (though bug bug 341950 is still present). Ria, can you verify and resolve this?
Safebrowsing still not working with 1.9a1_2006072103 (no Web Forgery alert), although the error appears to be gone.

*** This bug has been marked as a duplicate of 341950 ***
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → DUPLICATE
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.