343791 - Safebrowsing not working in trunk

Status: RESOLVED DUPLICATE of bug 341950

(Toolkit :: Safe Browsing, defect)

Description

[Ria Klaassen (not reading all bugmail)]

Today I saw a weird error in the JSConsole:

Error: junk after document element
Source File: chrome://browser/content/safebrowsing/report-phishing-overlay.xul
Line: 59, Column: 1
Source Code:
<?xml version="1.0"?>

So I tried out if there was something wrong with safebrowsing and it did not work indeed. The error was visible for the first time between 1.9a1_2006070516 and 1.9a1_2006070522.

But safebrowsing itself failed earlier: between 1.9a1_2006061721 and 1.9a1_2006061810. 

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2006-06-17+20%3A00&maxdate=2006-06-18+11%3A00

I tried also branch but there it works.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

This is fixed by attachment 228297 [details] [diff] [review] in bug 337484.

Comment 2

[Tony Chang (Google)]

Also, I should point out that the canvas overlay isn't working on trunk.  See bug 341950.  It may be the case that we need to do the dimmed overlay differently on trunk and on branch, but that's a low priority right now.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This is fixed by the patch in bug 337484, I believe (though bug bug 341950 is still present). Ria, can you verify and resolve this?

Comment 4

[Ria Klaassen (not reading all bugmail)]

Safebrowsing still not working with 1.9a1_2006072103 (no Web Forgery alert), although the error appears to be gone.

Comment 5

[Ria Klaassen (not reading all bugmail)]

*** This bug has been marked as a duplicate of 341950 ***