If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

support keygen params in crypto.generateCRMFRequest, do not crash

RESOLVED INVALID

Status

()

Core
Security: PSM
--
enhancement
RESOLVED INVALID
11 years ago
11 years ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

1.8 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

(Assignee)

Description

11 years ago
using the patch from bug 326159, visiting site http://kuix.de/misc/test3/crmf-ecc-384.php, clicking on a button to generate an ECC cert request, we crash.

This is because PSM function nsConvertToActualKeyGenParams refuses to produce key gen params when an JS input string is specified, and returns NULL.

Actually, that code is still at its initial checkin revision and a comment says:
  // We don't support passing in key generation arguments from
  // the JS code just yet.

This bug proposes to implement the code to convert input JS parameters to params suitable for NSS function calls.
(Assignee)

Comment 1

11 years ago
I filed bug 343868 to request that NSS fails gracefully on null pointers.
Depends on: 343868
(Assignee)

Comment 2

11 years ago
This bug is now INVALID.
Bug 326159 introduced the ability to pass in parameters, and the test case mentioned in this bug is not compatible with the API chosen.
And there is no crash.
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.