Closed Bug 343867 Opened 19 years ago Closed 18 years ago

support keygen params in crypto.generateCRMFRequest, do not crash

Categories

(Core :: Security: PSM, enhancement)

Product:
Core
Component:
Security: PSM
Version:
1.8 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: KaiE, Assigned: KaiE)

References

(
URL
)

Details

using the patch from bug 326159, visiting site http://kuix.de/misc/test3/crmf-ecc-384.php, clicking on a button to generate an ECC cert request, we crash. This is because PSM function nsConvertToActualKeyGenParams refuses to produce key gen params when an JS input string is specified, and returns NULL. Actually, that code is still at its initial checkin revision and a comment says: // We don't support passing in key generation arguments from // the JS code just yet. This bug proposes to implement the code to convert input JS parameters to params suitable for NSS function calls.
I filed bug 343868 to request that NSS fails gracefully on null pointers.
Depends on: 343868
This bug is now INVALID. Bug 326159 introduced the ability to pass in parameters, and the test case mentioned in this bug is not compatible with the API chosen. And there is no crash.
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.