343883 - Misleading localization note in browser.dtd

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Marek Stępień [:marcoos, inactive]]

browser.dtd contains this misleading L10n note:

<!-- LOCALIZATION NOTE : FILE Do not translate accesskey and commandkey --> 

This is wrong. Translating accesskeys is an important part of localization.

For example, if we had left "F" as accesskey to the file menu (which is "Plik" in Polish), we would have ended up with this menu visible as "Plik (F)".

None of the existing l10ns obey this localization note, but it is misleading to newcomers. This .l10n post is an example: http://tinyurl.com/oefme

So, the correct L10n note should be just:

<!-- LOCALIZATION NOTE : FILE Do not translate commandkeys -->

Patch for 1.8 and trunk follows.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Change the note as described above

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 228440 [details] [diff] [review]
Change the note as described above

Let's pick a browser peer for review.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 228440 [details] [diff] [review]
Change the note as described above

r+a=mconnor on behalf of drivers for this trival change

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.25.2.22
mozilla/browser/locales/en-US/chrome/browser/browser.dtd 	1.51

Comment 5

[Marek Stępień [:marcoos, inactive]]

v.

Comment 6

[Gintautas Grigas]

Localization note "Do not translate commandkeys" is too restrictive and prevents localization all command keys including those are reasonable to localize. I think would be better more democratic comment e. g. "Some command keys may be not translated"