Last Comment Bug 343941 - Audit Localizable.strings (and other .strings files) for typos/style guide and clarity
: Audit Localizable.strings (and other .strings files) for typos/style guide an...
Status: RESOLVED FIXED
: fixed1.8.1.1
Product: Camino Graveyard
Classification: Graveyard
Component: General (show other bugs)
: unspecified
: PowerPC Mac OS X
-- normal (vote)
: Camino1.5
Assigned To: froodian (Ian Leue)
:
:
Mentors:
: 349415 (view as bug list)
Depends on:
Blocks: 325880
  Show dependency treegraph
 
Reported: 2006-07-07 22:25 PDT by Smokey Ardisson (offline for a while; not following bugs - do not email)
Modified: 2006-11-01 07:41 PST (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
New Strings files (11.39 KB, application/zip)
2006-10-30 16:33 PST, froodian (Ian Leue)
alqahira: review+
stuart.morgan+bugzilla: superreview+
Details
String changes (3.80 KB, patch)
2006-10-30 16:34 PST, froodian (Ian Leue)
alqahira: review+
stuart.morgan+bugzilla: superreview+
Details | Diff | Splinter Review

Description User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-07-07 22:25:03 PDT
Just like we're doing with prefPanes, we need to audit the Localizable.strings files (there are multiple ones, as well as .strings files for Certifs and such) for typos/style guide issues and clarity.

For instance, the pop-up strings are "popup" while the rest of the app is "pop-up".  (The message there could maybe mention the Exceptions list to inform people of that feature, but it's already quite a long message...).
Comment 1 User image froodian (Ian Leue) 2006-08-23 19:41:33 PDT
*** Bug 349415 has been marked as a duplicate of this bug. ***
Comment 2 User image froodian (Ian Leue) 2006-08-23 19:49:46 PDT
Toolbar audit:

- Replace all instances of "current page" with "this page"
- Change "Close the current tab" to "Close this tab"
- In "Open a new message in your mail program with the URL of the current page" s/URL/location
- "Show recently visited pages organized by date" needs to lose the "organized by date"
- "Fill fields on this web page with your Address Book information" needs to lose the "web"
- Change "Go to home page" to ""Go to your home page"
- Change "Show the download manager" to "Show the Downloads window"
Comment 3 User image froodian (Ian Leue) 2006-09-18 14:00:12 PDT
Delete

"CloseWindowWithMultipleTabsCheckboxLabel" = "Don’t show this warning again";
"QuitWithMultipleTabsCheckboxLabel" = "Don’t show this warning again";

And replace with

"DontShowWarningAgainCheckboxLabel" = "Don’t show this warning again";

This will require minimal code changes as well.
Comment 4 User image Stuart Morgan 2006-10-21 13:06:37 PDT
This needs to get wrapped up soon. We don't want to be doing lots of strings changes at the last minute or it'll hurt localization.
Comment 5 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-10-26 16:23:45 PDT
The pop-up strings seem to be gone.

Delete (as part of comment 3)
"CloseMultipleWindowsCheckboxLabel" = "Don’t show this warning again";

Change:
"Bookmark Manager" = "Bookmark Manager"; -> Bookmarks Manager per cbo style

/* Error importing bookarks */ -> /* Error importing bookmarks */

- All instances of "web site" to "website" per cbo style (this is the only change I see that is needed in CertificateDialogs.strings, Privacy's loc.strings)

- All instances of "occured" -> "occurred"
- All instances of "MacOS X" -> "Mac OS X"
- All instances of "accessibililty" -> "accessibility"

I think the way to go about this is have someone (froodian) post updated .strings files for the 3 files that need changes, as well as the patch, and then seek review ("verification") on those....

If anyone else has .strings pet peeves, speak now....
Comment 6 User image froodian (Ian Leue) 2006-10-30 16:33:51 PST
Created attachment 244148 [details]
New Strings files

- New Localizable.strings (in resources/localized/Eng)
- New CertificateDialogs.strings
- New Localizable.strings (for History prefpane) "web site" -> "website"
- New Localizable.strings (for Privacy prefpane) "web site" -> "website"

Other changes:

All instances of "certificate authority" -> "Certificate Authority" (to match what most of them are already)
Comment 7 User image froodian (Ian Leue) 2006-10-30 16:34:24 PST
Created attachment 244149 [details] [diff] [review]
String changes
Comment 8 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-10-30 22:12:47 PST
Comment on attachment 244148 [details]
New Strings files

These look OK, except you missed deleting 
"QuitWithMultipleTabsCheckboxLabel" = "Don’t show this warning again";
from the main Localizable.strings file.

r=ardissone if you promise to make that change in your local copy as soon as you read this ;)
Comment 9 User image Smokey Ardisson (offline for a while; not following bugs - do not email) 2006-10-30 22:13:14 PST
Comment on attachment 244149 [details] [diff] [review]
String changes

Patch looks good; r=ardissone on what may be my only code review ever ;)
Comment 10 User image Stuart Morgan 2006-10-31 21:39:33 PST
Comment on attachment 244148 [details]
New Strings files

sr=me
Comment 11 User image froodian (Ian Leue) 2006-11-01 07:41:17 PST
Checked in on 1.8branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.