34402 - Need adjustable buffer sizes in nsSocketTransport

Status: RESOLVED WONTFIX

(Core :: Networking, defect, P3)

Description

[ruslan]

Buffer sizes should not be hardcoded, but be configurable or dynamically 
adjustable depending on the connection.

Comment 1

[Warren Harris]

I believe they are settable via SetBufferSegmentSize/SetBufferMaxSize. The 
constants are just the defaults when you don't say anything else.

Comment 2

[ruslan]

Yes but we need to adjust them based on the response from the site and/or prefs?

Comment 3

[Warren Harris]

Oh -- I don't think adjusting them after calling AsyncRead currently works. We 
would have to give the ability to change them on nsPipe. It might optimize 
things slightly, but the main reason for the buffer size parameter was to 
throttle the amount of data that would be delivered to the main thread in any 
given OnDataAvailable call, thereby allowing it to return to the event loop and 
drive the UI. Optimizing the transfer rate by minimizing allocations is probably 
the least of our worries right now.

Comment 4

[Warren Harris]

Moving to M17 which is now considered part of beta2.

Comment 5

[Gagan]

pulling in ruslan's necko bugs ->darin

Comment 6

[Gagan]

Hmmm... seems like it didn't really go to darin. 

Comment 7

[benc]

mass move, v2.
qa to me.

Comment 8

[benc]

while Bradley is looking at performance...

Comment 9

[Cathleen]

change milestone to 0.9.8  (from triage meeting)

Comment 10

[Darin Fisher]

i don't think this is going to be a critical performance/api issue for mozilla1.0

-> future

Comment 11

[Patrick McManus [:mcmanus]]

the number of buffers used is an issue for the main thread, but we don't need dynamically sized ones.