Buffer sizes should not be hardcoded, but be configurable or dynamically adjustable depending on the connection.
I believe they are settable via SetBufferSegmentSize/SetBufferMaxSize. The constants are just the defaults when you don't say anything else.
Yes but we need to adjust them based on the response from the site and/or prefs?
Oh -- I don't think adjusting them after calling AsyncRead currently works. We would have to give the ability to change them on nsPipe. It might optimize things slightly, but the main reason for the buffer size parameter was to throttle the amount of data that would be delivered to the main thread in any given OnDataAvailable call, thereby allowing it to return to the event loop and drive the UI. Optimizing the transfer rate by minimizing allocations is probably the least of our worries right now.
Moving to M17 which is now considered part of beta2.
Target Milestone: M16 → M17
pulling in ruslan's necko bugs ->darin
Assignee: ruslan → gagan
Status: ASSIGNED → NEW
Target Milestone: Future → M19
Hmmm... seems like it didn't really go to darin.
Assignee: gagan → darin
Target Milestone: --- → mozilla1.0
mass move, v2. qa to me.
QA Contact: tever → benc
while Bradley is looking at performance...
change milestone to 0.9.8 (from triage meeting)
Target Milestone: mozilla1.0 → mozilla0.9.8
i don't think this is going to be a critical performance/api issue for mozilla1.0 -> future
Target Milestone: mozilla0.9.8 → Future
Assignee: darin → nobody
QA Contact: benc → networking
Target Milestone: Future → ---
the number of buffers used is an issue for the main thread, but we don't need dynamically sized ones.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.