344143 - No Error messages displayed for LDAP Autocomplete (Couldn't convert chrome URL ... ldapAutoCompErrs.properties)

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[Mark Banner (:standard8)]

This is a regression from bug 263042, when an error occurs during autocomplete when using the compose window, I get:

Couldn't convert chrome URL: chrome://mailnews/locale/addressbook/ldapAutoCompErrs.properties
###!!! ASSERTION: nsAbLDAPAutoCompleteFormatter::FormatException(): error getting general error from bundle chrome://mailnews/locale/addressbook/ldapAutoCompErrs.properties: 'Error', file /mozilla/master/mozilla/mailnews/addrbook/src/nsAbLDAPAutoCompFormatter.cpp, line 222
###!!! ASSERTION: nsLDAPAutoCompleteSession::FinishAutoCompleteLookup(): error calling FormatException(): 'Error', file /mozilla/master/mozilla/mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp, line 1327

The problem is the chrome URL should be
chrome://messenger/locale/addressbook/ldapAutoCompErrs.properties
not
chrome://mailnews/locale/addressbook/ldapAutoCompErrs.properties

As the attachment 201545 [details] [diff] [review] didn't go into branch, then this won't need to go into branch.

I also noticed a couple of the errors have the wrong url displayed so I'll fix that at the same time.

Comment 1

[Mark Banner (:standard8)]

Attachment: The fix

This patch fixes the chrome url and corrects and simplifies some of the debug output.

Comment 2

[David :Bienvenu]

Comment on attachment 228704 [details] [diff] [review]
The fix

cool, thx!

Comment 3

[Mark Banner (:standard8)]

Patch checked in.