344144 - phishing warning dialog has a link to a page with references to Bon Echo

Status: VERIFIED INVALID

(Toolkit :: Safe Browsing, defect)

Description

[juan becerra [:juanb]]

If you visit a phishing site you get a dialog box with a warning that has a link to a page that tells you how Firefox protects you. This page makes references to Bon Echo as opposed to Firefox.

To recreate:
1. Go to http://www.google.com/tools/firefox/toolbar/FT2/intl/en/phish-o-rama.html
2. Click on the "how Firefox protects you link" in the dialog box

Expected: An info page that says how Firefox protects me against phishing. (This is for the beta release which should have been rebranded by now)

Actual: The page has referecens to Bon Echo.

Comment 1

[juan becerra [:juanb]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1b1) Gecko/20060707 Firefox/2.0b1

Comment 2

[Axel Hecht [:Pike]]

Yikes, did this bug slip?

Can we make this use a preference and catch the goodness of bug 347944?

Comment 3

[Dietrich Ayala (:dietrich)]

The dtd uses the entity &brandShortName; which is the correct way to do this AFAICT. Both brand.dtd files are correct. I'll fix it with formatURL if I can't find out why &brandShortName; is incorrect here.

Comment 4

[u60234]

The problem is that the URL in
http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/chrome/browser/safebrowsing/phishing-afterload-warning-message.dtd#9
points to a Bon Echo page:

<!ENTITY safeb.palm.message.p2.linkURL "http://www.mozilla.org/projects/bonecho/anti-phishing/">

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

This was fixed in bug 348076

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Although it seems the line in the DTD file was only removed on the branch (with a comment referencing that bug, but none of the patches in that bug seem to have such a patch).

Comment 7

[Reed Loden [:reed]]

Clearing blocking flag.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #6)
> Although it seems the line in the DTD file was only removed on the branch (with
> a comment referencing that bug, but none of the patches in that bug seem to
> have such a patch).

That removal isn't actually what fixed the bug, that entity was just unused and caused confusion. I've removed the entity on the trunk as well.