<xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?"

RESOLVED FIXED

Status

()

defect
--
minor
RESOLVED FIXED
13 years ago
11 years ago

People

(Reporter: jruderman, Assigned: mats)

Tracking

(Blocks 1 bug, {assertion, testcase})

Trunk
PowerPC
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

182 bytes, application/vnd.mozilla.xul+xml
Details
1.60 KB, patch
sicking
: review+
sicking
: superreview+
Details | Diff | Splinter Review
<xul:observes/> with no attributes triggers "ASSERTION: getElementById(""), fix caller?".

Bug 296237 covers turning this assertion into some kind of warning, but I don't think the warning there would be appropriate for just having a <xul:observes/> with no attributes.
Posted file testcase
Blocks: 344486
Posted patch Patch rev. 1Splinter Review
Return NS_FINDBROADCASTER_NOT_FOUND when there is no/empty "element" attribute.
(as we do in the "generic element" case when there is no "observes"/"command")

http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/xul/document/src/nsXULDocument.cpp&rev=1.723&root=/cvsroot&mark=3943,3954,3951,3956,3957,3967,3968,3982#3911
Assignee: nobody → mats.palmgren
Status: NEW → ASSIGNED
Attachment #229189 - Flags: superreview?(bugmail)
Attachment #229189 - Flags: review?(bugmail)
Attachment #229189 - Flags: superreview?(bugmail)
Attachment #229189 - Flags: superreview+
Attachment #229189 - Flags: review?(bugmail)
Attachment #229189 - Flags: review+
Checked in to trunk at 2006-07-20 01:11 PDT.

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Crashtest checked in.
Flags: in-testsuite+
Component: XP Toolkit/Widgets: XUL → XUL
QA Contact: xptoolkit.xul → xptoolkit.widgets
You need to log in before you can comment on or make changes to this bug.