In <button.xml>, multiple Strict "Warning: function onxblkeypress does not always return a value"

VERIFIED FIXED in mozilla1.8.1beta2

Status

()

Core
XUL
--
minor
VERIFIED FIXED
12 years ago
12 years ago

People

(Reporter: Simon Bünzli, Assigned: Simon Bünzli)

Tracking

(Blocks: 1 bug, {fixed-seamonkey1.1a, fixed1.8.1})

1.8 Branch
mozilla1.8.1beta2
fixed-seamonkey1.1a, fixed1.8.1
Points:
---
Bug Flags:
blocking1.8.1 -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [verified-seamonkey1.1a], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

12 years ago
Warning: function onxblkeypress does not always return a value
Source file: chrome://global/content/bindings/button.xml
Line: 172, Column: 5
Source code:
      
 ----------
Warning: function onxblkeypress does not always return a value
Source file: chrome://global/content/bindings/button.xml
Line: 162, Column: 18
Source code:
            return; 
 ----------
Warning: function onxblkeypress does not always return a value
Source file: chrome://global/content/bindings/button.xml
Line: 153, Column: 16
Source code:
          return; 
 ----------
Warning: function onxblkeypress does not always return a value
Source file: chrome://global/content/bindings/button.xml
Line: 145, Column: 16
Source code:
          return;  // No printable char pressed, not a potential accesskey 


Steps to Reproduce:
* Enable the pref javascript.options.strict
* Load the URL


Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060711 BonEcho/2.0b1 Firefox/1.5 ID:2006071104
(Assignee)

Updated

12 years ago
Blocks: 296661
Severity: normal → trivial
(Assignee)

Comment 1

12 years ago
Created attachment 228836 [details] [diff] [review]
don't return useless values
Assignee: nobody → zeniko
Status: NEW → ASSIGNED
Attachment #228836 - Flags: first-review?(mconnor)
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060711 SeaMonkey/1.1a] (nightly) (W98SE)

[
Warning: function onxblkeypress does not always return a value
Source File: chrome://global/content/bindings/button.xml
Line: 156, Column: 16
Source Code:
          return;  // No printable char pressed, not a potential accesskey

Warning: function onxblkeypress does not always return a value
Source File: chrome://global/content/bindings/button.xml
Line: 164, Column: 16
Source Code:
          return;

Warning: function onxblkeypress does not always return a value
Source File: chrome://global/content/bindings/button.xml
Line: 173, Column: 18
Source Code:
            return;

Warning: function onxblkeypress does not always return a value
Source File: chrome://global/content/bindings/button.xml
Line: 183, Column: 5
Source Code:
      
]
Severity: trivial → minor
Component: XUL Widgets → XP Toolkit/Widgets
Flags: first-review?(mconnor)
Product: Toolkit → Core
Summary: Strict warnings in button.xml → In <button.xml>, multiple Strict "Warning: function onxblkeypress does not always return a value"
Version: unspecified → 1.8 Branch
Attachment #228836 - Flags: review?(mconnor)
(Assignee)

Comment 3

12 years ago
Created attachment 229006 [details] [diff] [review]
fix for Toolkit and XPFE
Attachment #228836 - Attachment is obsolete: true
Attachment #229006 - Flags: review?(mconnor)
Attachment #228836 - Flags: review?(mconnor)
Attachment #229006 - Flags: superreview?(neil)

Comment 4

12 years ago
Comment on attachment 229006 [details] [diff] [review]
fix for Toolkit and XPFE

For some reason the owner of bug 343690 hasn't checked his patch in so you'll find you'll need to update this patch when he does.
Attachment #229006 - Flags: superreview?(neil) → superreview+
The checkin for that other bug happened today
[
2006-07-17 06:38	smontagu%smontagu.org
]
I hope this one can be prioritized,
as I get it all the time when using Ctrl-Enter to send an email.
[And as I have an added getAttention() in my local install...]
(Assignee)

Updated

12 years ago
Flags: blocking1.8.1?
Target Milestone: --- → mozilla1.8.1beta2
Comment on attachment 229006 [details] [diff] [review]
fix for Toolkit and XPFE

r=me, please request approval on the updated patch when its done
Attachment #229006 - Flags: review?(mconnor) → review+
Not going to block on this, but if a well-baked patch exists and gets nominated for approval1.8.1 tomorrow, we'd like to take it!
Flags: blocking1.8.1? → blocking1.8.1-
(Assignee)

Comment 9

12 years ago
Created attachment 229887 [details] [diff] [review]
unbitrotted fix for Toolkit and XPFE
Attachment #229006 - Attachment is obsolete: true
Attachment #229887 - Flags: approval1.8.1?
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed]
mozilla/xpfe/global/resources/content/bindings/button.xml 	1.33
mozilla/toolkit/content/widgets/button.xml 	1.17
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
OS: Windows XP → All
Hardware: PC → All
Resolution: --- → FIXED
Whiteboard: [checkin needed]

Updated

12 years ago
Attachment #229887 - Flags: approval1.8.1? → approval1.8.1+
(Assignee)

Updated

12 years ago
Whiteboard: [checkin needed (1.8 branch)]
mozilla/xpfe/global/resources/content/bindings/button.xml 	1.27.4.4
mozilla/toolkit/content/widgets/button.xml 	1.12.4.4
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b1) Gecko/20060723 SeaMonkey/1.1a] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Thanks !
Keywords: fixed-seamonkey1.1a
Whiteboard: [verified-seamonkey1.1a]
(Assignee)

Updated

12 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.