Closed Bug 344265 Opened 18 years ago Closed 18 years ago

jsautokw.h isn't regenerated when jskeyword.tbl changes

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9alpha1

People

(Reporter: mrbkap, Assigned: mrbkap)

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

Fix
805 bytes, patch
brendan
: review+
benjamin
: superreview+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
I bet most of the depend tinderboxen aren't getting 'let' love because of this.
Attached patch Fix — — Splinter Review 
brendan was wondering why we weren't generating .deps for this, but I didn't know the answer.
Assignee: general → mrbkap
Status: NEW → ASSIGNED
Attachment #228832 - Flags: superreview?(benjamin)
Attachment #228832 - Flags: review?(brendan)
Attachment #228832 - Flags: superreview?(benjamin) → superreview+
Cc'ing cls for insight in why HOST_OBJECTS don't have dependency auto-capture.

/be
Attachment #228832 - Flags: review?(brendan) → review+
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Summary: jsautokw.h isn't regenterated when jskeyword.tbl changes → jsautokw.h isn't regenerated when jskeyword.tbl changes
on trunk winxp opt shell, touch jskeyword.tbl; make -f Makefile.ref BUILD_OPT=1; shows jsautokw.h is updated.
Status: RESOLVED → VERIFIED
Flags: in-testsuite-
Comment on attachment 228832 [details] [diff] [review]
Fix

For branch developer (and tinderbox) incremental build sanity, this should be checked into the 1.8 branch too.

/be
Attachment #228832 - Flags: approval1.8.1?
Attachment #228832 - Flags: approval1.8.1? → approval1.8.1+
Keywords: fixed1.8.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: