344334 - Adding <xul:preference> and <xul:preferences> to document causes uncatchable "Permission denied to get property UnnamedClass.classes"

Status: RESOLVED WORKSFORME

(Core :: XUL, defect)

Description

[Jesse Ruderman]

The testcase triggers
Error: uncaught exception: Permission denied to get property UnnamedClass.classes

Similar to bug 344211.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Jesse Ruderman]

This bug makes it difficult for me to test the <xul:preference> and <xul:preferences> elements.  It would be nice if this were fixed.

Comment 3

[Neil Deakin]

Attachment: check to ensure parent is a preferences element

Comment 4

[Neil Deakin]

This fixes some exceptions when a preference is used outside of a preferences element.

The permission error is caused because the four fields in the <preference> binding are initialized to services, which can't be used outside of chrome. A preference element isn't actually useful for anything unless permissions allow it, so its arguably correct to just throw a permission error. But maybe we could put some try/catch blocks around the four <field>s in preferences.xml. Thoughts?

Comment 5

[Asaf Romano (gone)]

Comment on attachment 261095 [details] [diff] [review]
check to ensure parent is a preferences element

Hrm, we still save the actual pref from the preference_s_ binding though, right? If so, I think we should continue to throw here rather than fail silently.

Jesse, what were you trying to test here? these bindings are intentionally not working in content context...

Comment 6

[Jesse Ruderman]

Throwing is fine, but throwing an uncatchable exception breaks my testing script.

Comment 7

[Jesse Ruderman]

WFM on trunk, perhaps because of changes to when XBL bits execute.

Neil Deakin, is the patch in comment 3 still desirable?