344366 - data is still collected after setting metrics.upload.enable to false

Status: RESOLVED FIXED

(Toolkit Graveyard :: Data Collection/Metrics, defect)

Description

[Brian Ryner (not reading)]

Setting this pref to false should put us in the same state as if it was never set to true -- that is, all collection should be stopped.

Comment 1

[Brian Ryner (not reading)]

Attachment: patch

This patch clears out the config and data file, and stops all collectors, when we find the pref to be disabled.  I do this on startup, in addition to on pref-change notification, in case the pref was edited by hand.

Comment 2

[Marria Nazif]

Comment on attachment 228963 [details] [diff] [review]
patch


>+  nsCOMPtr<nsIFile> configFile;
>+  GetConfigFile(getter_AddRefs(configFile));
>+  if (configFile) {
>+    configFile->Remove(PR_FALSE);
>+  }
>+
>+  nsCOMPtr<nsILocalFile> dataFile;
>+  GetDataFile(&dataFile);
>+  if (dataFile) {
>+    dataFile->Remove(PR_FALSE);
>+  }

Does it make sense to check if these files exist before removing them? (Not sure it matters)


>+  if (!CollectionEnabled()) {
>+    MS_LOG(("Upload disabled or URI not set"));
>+    return NS_ERROR_ABORT;
>+  }

Fix logging to say only that upload is disabled

otherwise looks good

Comment 3

[Brian Ryner (not reading)]

(In reply to comment #2)
> Does it make sense to check if these files exist before removing them? (Not
> sure it matters)

I think that would actually be more expensive and not gain us anything.

Comment 4

[Brian Ryner (not reading)]

checked in

Comment 5

[Brian Ryner (not reading)]

*** Bug 341785 has been marked as a duplicate of this bug. ***