344368 - There should be a way to change spell checker settings in the options panel.

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement)

Description

[Frédéric Buclin]

Actually, the spellchecker is slow (bug 340326). But even if it were running at the speed of light, I still don't want to see all these red lines underlying patches I'm reviewing. It simply doesn't make sense! I know I can disable it on a per textarea basis, but I want a global pref to disable it all the time and for all pages (I already disabled it for Thunderbird). You can have it turned on by default but please let me disable it if I want to. Hidden prefs are not very friendly.

Comment 1

[Régis Caspar]

You should take a look at http://kb.mozillazine.org/Layout.spellcheckDefault

 -> WORSKFORME?

Comment 2

[Frédéric Buclin]

(In reply to comment #1)
> You should take a look at http://kb.mozillazine.org/Layout.spellcheckDefault
> 
>  -> WORSKFORME?

For the exact reason I gave in comment 0 ("Hidden prefs are not very friendly"), no, this is not WFM. It's not my job to guess what hidden prefs do and what they values can be.

Comment 3

[Régis Caspar]

> For the exact reason I gave in comment 0 ("Hidden prefs are not very
> friendly"), no, this is not WFM. It's not my job to guess what hidden prefs do
> and what they values can be.
So you what you want is not a global pref but a checkbox or something in the option panel.. 
This looks like a dupe of bug 341723
 
 -> changing summary

Comment 4

[Ria Klaassen (not reading all bugmail)]

Maybe related to Bug 343570?

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

See bug 340677 for pref panel changes targeted at beta2. This one feels like an "Advanced > Browsing" pref to me!

Comment 6

[Jeff Walden [:Waldo]]

This will be fixed after the final iteration of bug 340677 is completed; I'm pushing this to here as a followup bug, because it's easier to get reviews for small, disparate patches than for "everything" patches.

Comment 7

[Jeff Walden [:Waldo]]

Attachment: Patch -- "Check my spelling as I type"

Comments on the string welcome.  Also, tell me which preference value should be preserved when unchanged but never actually selectable using UI, because my notes indicate one thing but general consensus indicates that it's another; there's a big XXX at the relevant point in the code.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 230225 [details] [diff] [review]
Patch -- "Check my spelling as I type"

21:50 <@mconnor> Waldo: so how about this: take the t from certs.ask.accesskey, use the i from verify.accesskey for certs.ask.accesskey, and use the n for verify.accesskey?

toggle should be between 0 and 1, 2 is not what we want to expose to users by default.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 230225 [details] [diff] [review]
Patch -- "Check my spelling as I type"

As mconnor says, the checkbox should toggle between:

layout.spellcheckDefault=0 (checkbox unselected) 

and 

layout.spellcheckDefault=1 (checkbox selected). 

If a user goes into about:config and sets layout.spellcheckDefault=2, the checkbox should show as checked. Unchecking it will set it back to 0, rechecking it will set it back to 1 and the user will have to go back into about:config.

Comment 10

[Jeff Walden [:Waldo]]

Patch in on trunk; this'll make branch as part of the full-prefwindow patch for bug 345516.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Waldo, I've cleared the blocking-firefox2 flag as per your last comment. Please renominate if that's not what you meant.

Comment 12

[Brett Wilson]

This bug pulls in all sorts of sub-dependencies which make the spellcheck bugs dependencies much harder to sort through. Since this is under control, I'm clearing the blocking for the spellcheck bug. If this bothers you, you can put it back.