344384 - Double-click-drag misbehaves when dragging into empty lines (created by <br><br>)

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Uri Bernstein]

In the textarea above, type a few words, hit enter twice, then type some more.
Now double-click-and-drag from (e.g.) the last word in the top line into the empty line. Notice that the selection suddenly starts at the second word of the line.
The problem is not limited to textareas - it can be triggered by <br><br> in HTML. 

I'll attach a patch soon.

Comment 1

[Uri Bernstein]

Attachment: patch

GetPrimaryFrameFor doesn't work for non-text frames. GetFrameForNodeOffset is what I really want.

Sorry for not catching this earlier.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 228972 [details] [diff] [review]
patch

I should have caught that too.

Comment 3

[Uri Bernstein]

Attachment: what I checked in

I had to update for bug 343763, and I also added a null check on |frame|, just to be sure.

Comment 4

[Uri Bernstein]

Checking in layout/generic/nsSelection.cpp;
/cvsroot/mozilla/layout/generic/nsSelection.cpp,v  <--  nsSelection.cpp
new revision: 3.247; previous revision: 3.246
done