Closed
Bug 344484
Opened 19 years ago
Closed 19 years ago
gfxTextRun leaks lots of memory, at least with Pango
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: roc, Assigned: roc)
References
Details
(Keywords: memory-leak)
Attachments
(1 file)
|
5.47 KB,
patch
|
pavlov
:
review+
|
Details | Diff | Splinter Review |
gfxTextRun's destructor is not virtual, so the subclass destructor never gets called, leaking any heap-allocated string. This leak cripples current trunk cairo-gtk builds.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #229052 -
Flags: review?(pavlov)
|
||
Comment 2•19 years ago
|
||
Comment on attachment 229052 [details] [diff] [review]
fix
r=me for the 1 line change -- don't check in the mac stuff (or file a seperate bug)
Attachment #229052 -
Flags: review?(pavlov) → review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
oops, that mac stuff was unintentional.
Checked in the gfxFont change.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Comment 4•19 years ago
|
||
*** Bug 344038 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•