Mingw build error in nsDataObj.cpp

RESOLVED FIXED

Status

()

RESOLVED FIXED
12 years ago
12 years ago

People

(Reporter: martijn.martijn, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
I updated my tree, and now I get this build error:
SYMBOLS=1 -DMOZ_USER_DIR=\"Mozilla\" -DHAVE_STDINT_H=1 -DHAVE_INTTYPES_H=1 -DHAV
E_UINT64_T=1 -DMOZ_XUL=1 -DMOZ_PROFILELOCKING=1 -DMOZ_MORKREADER=1 -DMOZ_DLL_SUF
FIX=\".dll\" -DJS_THREADSAFE=1 -DMOZ_REFLOW_PERF=1 -DMOZ_REFLOW_PERF_DSP=1 -DMOZ
ILLA_LOCALE_VERSION=\"1.9a1\" -DMOZILLA_REGION_VERSION=\"1.9a1\" -DMOZILLA_SKIN_
VERSION=\"1.8\"  -D_MOZILLA_CONFIG_H_ -DMOZILLA_CLIENT /cygdrive/c/mozilla/mozil
la/widget/src/windows/nsDataObj.cpp
In file included from c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:46:
c:/mozilla/mozilla/widget/src/windows/nsDataObj.h:119: error: expected class-nam
e before '{' token
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:265: warning: `CLSID_nsDataO
bj' initialized and declared `extern'
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:265: warning: `__cdecl__' at
tribute only applies to function types
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp: In member function `virtual
 HRESULT nsDataObj::QueryInterface(const IID&, void**)':
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:332: error: `IID_IAsyncOpera
tion' was not declared in this scope
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:333: error: `IAsyncOperation
' has not been declared
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:333: error: expected `>' bef
ore '*' token
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:333: error: expected `(' bef
ore '*' token
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:333: error: expected primary
-expression before '>' token
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:333: error: expected `)' bef
ore ';' token
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:332: warning: unused variabl
e 'IID_IAsyncOperation'
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp: In member function `virtual
 HRESULT nsDataObj::GetFileDescriptor_IStreamA(FORMATETC&, STGMEDIUM&)':
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:1607: error: `FD_PROGRESSUI'
 was not declared in this scope
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:1607: warning: unused variab
le 'FD_PROGRESSUI'
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp: In member function `virtual
 HRESULT nsDataObj::GetFileDescriptor_IStreamW(FORMATETC&, STGMEDIUM&)':
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:1643: error: `FD_PROGRESSUI'
 was not declared in this scope
c:/mozilla/mozilla/widget/src/windows/nsDataObj.cpp:1643: warning: unused variab
le 'FD_PROGRESSUI'
make[6]: *** [nsDataObj.o] Error 1
make[6]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget/src/windows'
make[5]: *** [libs] Error 2
make[5]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget/src'
make[4]: *** [libs] Error 2
make[4]: Leaving directory `/cygdrive/c/mozilla/mozilla/widget'
make[3]: *** [libs_tier_9] Error 2
make[3]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[2]: *** [tier_9] Error 2
make[2]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make[1]: *** [alldep] Error 2
make[1]: Leaving directory `/cygdrive/c/mozilla/mozilla'
make: *** [alldep] Error 2


Regression from bug 267426, I guess.

Comment 1

12 years ago
Think this is a mingw bug, those are standard windows enums and interfaces - should be present. We could explicitly define them in nsDataObj.h or somewhere to fix this build error.
Don't have mingw build system installed right now.
How are bugs like this fixed?
(Reporter)

Comment 2

12 years ago
Sometimes defines are added in Mozilla's codebase, see bug 328182.
Sometimes mingw is being fixed and everyone is forced to upgrade, see bug 328499. But I think that's something that only can happen on trunk. And for bug 267426 the plan is it to land on branch, right? 

Comment 3

12 years ago
(In reply to comment #2)
> 328499. But I think that's something that only can happen on trunk. And for bug
> 267426 the plan is it to land on branch, right? 
> 
Yes, there is such a plan. So it'd be better to define stuff inplace, am I right?
By the way, where mingw build instructions are?
(Reporter)

Comment 4

12 years ago
You can find build instructions here:
http://gemal.dk/mozilla/build.html
To be honest, I'm not sure if you're responsible for fixing this. Mingw is not an officially supported build platform.
(Reporter)

Updated

12 years ago
Blocks: 203303

Comment 5

12 years ago
Please note, even if this bug is fixed we have also bug 341128 where we wait for its patch to be checked in. 

Comment 6

12 years ago
did the last patch for bug 203307 fixed this error? if so mark it fixed.
(Reporter)

Comment 7

12 years ago
(In reply to comment #6)
> did the last patch for bug 203307 fixed this error? if so mark it fixed.

Thanks! I believe you. If it isn't fixed, I'll notice it soon enough.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.