Closed
Bug 344583
Opened 19 years ago
Closed 19 years ago
Random bits of cleanup in layout/generic
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
People
(Reporter: sharparrow1, Assigned: sharparrow1)
Details
Attachments
(1 file)
|
26.09 KB,
patch
|
roc
:
review+
roc
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•19 years ago
|
||
Comment on attachment 229150 [details] [diff] [review]
Patch
- // Make sure the child is at least as tall as our max size (the containing window)
- if (aDesiredSize.height < aReflowState.availableHeight &&
- aReflowState.availableHeight != NS_UNCONSTRAINEDSIZE) {
- aDesiredSize.height = aReflowState.availableHeight;
- }
Can you tell me why this is OK to remove?
Attachment #229150 -
Flags: superreview+
Attachment #229150 -
Flags: review?(roc)
Attachment #229150 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
(In reply to comment #2)
> (From update of attachment 229150 [details] [diff] [review] [edit])
> - // Make sure the child is at least as tall as our max size (the containing window)
> - if (aDesiredSize.height < aReflowState.availableHeight &&
> - aReflowState.availableHeight != NS_UNCONSTRAINEDSIZE) {
> - aDesiredSize.height = aReflowState.availableHeight;
> - }
>
> Can you tell me why this is OK to remove?
A few lines below that:
if (aReflowState.availableHeight != NS_UNCONSTRAINEDSIZE) {
aDesiredSize.height = aReflowState.availableHeight;
}
(http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsPageFrame.cpp&rev=3.160&mark=201-203#201)
(Oddly enough, both blocks were added in the same revision; I have no idea why)
|
|
Assignee | |
Comment 4•19 years ago
|
||
Checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Core Graveyard
|
||
Updated•7 years ago
|
Component: Layout: Misc Code → Layout
Product: Core Graveyard → Core
You need to log in
before you can comment on or make changes to this bug.
Description
•