Closed Bug 344639 Opened 19 years ago Closed 19 years ago

admintree should not stick tree creation in the middle of tree management

Categories

(Webtools Graveyard :: Tinderbox, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: timeless, Assigned: cls)

References

()

Details

Attachments

(1 file)

there are two problems 1. you can't see or change all the tree configuration (e.g. what branch the tree you're editing is using) 2. in the middle of all the tree changes you can make is an unrelated form for creating a new tree.
Attached patch v1.0Splinter Review
Actually, you can't change any of the variables that are set in the initial tree creation. Given that we now store sensitive info there, that's probably a good thing. I agree that we shouldn't be mixing new tree creation with existing tree management.
Assignee: morgamic → cls
Status: NEW → ASSIGNED
Attachment #229594 - Flags: review?(timeless)
Comment on attachment 229594 [details] [diff] [review] v1.0 the code could use a refactoring, because it's still logically in between things. but yeah. i'm an end user, i only care about what i see. thanks :)
Attachment #229594 - Flags: review?(timeless) → review+
Checking in webtools/tinderbox/admintree.cgi; /cvsroot/mozilla/webtools/tinderbox/admintree.cgi,v <-- admintree.cgi new revision: 1.25; previous revision: 1.24 done Checking in webtools/tinderbox/showbuilds.pl; /cvsroot/mozilla/webtools/tinderbox/showbuilds.pl,v <-- showbuilds.pl new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: