Closed Bug 344642 Opened 17 years ago Closed 17 years ago

[SessionStore] Get rid of the unnused "Undo Close Window" code

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 2 beta2

People

(Reporter: zeniko, Assigned: zeniko)

References

Details

(Keywords: fixed1.8.1)

Attachments

(1 file)

The code is mostly there, it's just not exposed to extensions and thus of no value at all (except for filling RAM). The Undo Close Window API should pretty much mirror the Undo Close Tab API. Additionally browser.sessionstore.max_windows_undo should default to 0 since in most cases this functionality won't be used at all.

An alternative approach would be to completely drop all Undo Close Window code and let extensions implement it on their own should they want to. An extension would then have to get a window's state onunload and restore it as a partial session (see bug 344640 for the required API).
It's probably better to leave this to extensions than to ship hardly tested code which won't be of any use except with an extension.
Attachment #229882 - Flags: review?(dietrich)
Drivers: There must be a patch of some kind to this bug since we're currently storing all data for the 10 last closed windows (since startup) for no reason at all.
Flags: blocking-firefox2?
Summary: [SessionStore] Add an API for Undo Close Window (and disable it by default) → [SessionStore] Get rid of the unnused "Undo Close Window" code
Target Milestone: --- → Firefox 2 beta2
Flags: blocking-firefox2? → blocking-firefox2+
Status: NEW → ASSIGNED
Whiteboard: [has patch][needs review dietrich]
Attachment #229882 - Flags: review?(dietrich) → review+
Checked in on trunk. We should evaluate this again for a later release. However seems a low priority given the trend of favoring tabs instead of windows.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][needs review dietrich] → [has patch]
Comment on attachment 229882 [details] [diff] [review]
remove all Undo Close Window code

Very low risk, removing unused code.
Attachment #229882 - Flags: approval1.8.1?
Whiteboard: [has patch] → [has patch][need approval]
Whiteboard: [has patch][need approval] → [has patch]
Comment on attachment 229882 [details] [diff] [review]
remove all Undo Close Window code

a=drivers. Please land this on the MOZILLA_1_8_BRANCH.
Attachment #229882 - Flags: approval1.8.1? → approval1.8.1+
Assignee: nobody → zeniko
Whiteboard: [has patch] → [checkin needed (1.8 branch)]
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
Verified using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2 ID:2006082803.
Status: RESOLVED → VERIFIED
Blocks: 360408
I filed bug 360408 to investigate putting the "Undo Close Window" code back in (but with a "Recently Closed Windows" menu this time).
Component: General → Session Restore
QA Contact: general → session.restore
You need to log in before you can comment on or make changes to this bug.