344673 - xforms.xpi not being built anymore

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060714 BonEcho/2.0b1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060714 BonEcho/2.0b1

xforms.xpi not being built for win and nix (maybe mac too) since around time of 2006/07/13 nightlies. 

Reproducible: Always

Actual Results:  
cut/paste from a build log:

mkdir c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms && cd c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms && c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/build/autoconf/make-makefile -t c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla -d ../..
make -C c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms
make: Entering directory `/cygdrive/c/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms'
make: *** No targets specified and no makefile found.  Stop.
make: Leaving directory `/cygdrive/c/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms'



Expected Results:  
xforms.xpi should be built and ftp'ed to server

Looks like it's probably since checkin of bug 339568 .

Comment 1

[Robert Helmer [:rhelmer]]

It looks like Mac is working; this is probably because the patch in bug 339568 requires xforms to be explicitly enabled in tinder-config.pl now. I'll enable it today for the tinderboxes that should be building it.

Comment 2

[jhp (no longer active)]

From the log, it looks like it is entering into the XForms build code in build-seamonkey-util.pl.  So $Settings::BuildXForms must be set.  But it is not generating the Makefile (from the make-makefile call).

When I created the patch in bug 339568, I was using an OBJDIR.  But it looks like this Win32 tbox isn't.  So maybe the "mkdir" call is failing (since that directory already exists), and "make-makefile" doesn't get called?

Comment 3

[jhp (no longer active)]

Attachment: possible fix

Something like this.  Or just make all affected tinderboxes build with an OBJDIR.

Comment 4

[jhp (no longer active)]

Fix checked in.  Please reopen if this patch doesn't fix the problem.