Closed Bug 344673 Opened 19 years ago Closed 19 years ago

xforms.xpi not being built anymore

Categories

(Firefox Build System :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: aja+bugzilla, Unassigned)

Details

Attachments

(1 file)

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060714 BonEcho/2.0b1 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b1) Gecko/20060714 BonEcho/2.0b1 xforms.xpi not being built for win and nix (maybe mac too) since around time of 2006/07/13 nightlies. Reproducible: Always Actual Results: cut/paste from a build log: mkdir c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms && cd c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms && c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/build/autoconf/make-makefile -t c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla -d ../.. make -C c:/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms make: Entering directory `/cygdrive/c/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms' make: *** No targets specified and no makefile found. Stop. make: Leaving directory `/cygdrive/c/builds/tinderbox/Fx-Trunk-Cairo/WINNT_5.2_Depend/mozilla/extensions/xforms' Expected Results: xforms.xpi should be built and ftp'ed to server Looks like it's probably since checkin of bug 339568 .
It looks like Mac is working; this is probably because the patch in bug 339568 requires xforms to be explicitly enabled in tinder-config.pl now. I'll enable it today for the tinderboxes that should be building it.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
From the log, it looks like it is entering into the XForms build code in build-seamonkey-util.pl. So $Settings::BuildXForms must be set. But it is not generating the Makefile (from the make-makefile call). When I created the patch in bug 339568, I was using an OBJDIR. But it looks like this Win32 tbox isn't. So maybe the "mkdir" call is failing (since that directory already exists), and "make-makefile" doesn't get called?
Attached patch possible fixSplinter Review
Something like this. Or just make all affected tinderboxes build with an OBJDIR.
Attachment #229253 - Flags: review?(rhelmer)
Attachment #229253 - Flags: review?(rhelmer) → review+
Fix checked in. Please reopen if this patch doesn't fix the problem.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
Component: Build Config → General
Product: Firefox → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: