344694 - Conflict of linkage-specification for "MimeExternalObjectClass mimeExternalObjectClass"

Status: RESOLVED FIXED

(MailNews Core :: MIME, defect)

Description

[Caio Tiago Oliveira (asrail)]

According with section 7.5 of http://www.open-std.org/jtc1/sc22/wg21/docs/wp/html/oct97/dcl.html a explicit linkage specification should be declared before an implicit.

GCC 4.2 will break the code which doesn't conform to it.

So, it's lacking an explicit declaration of "MimeExternalObjectClass mimeExternalObjectClass" in mimeeobj.h.

Comment 1

[Caio Tiago Oliveira (asrail)]

Attachment: Adds an explicit linkage to "MimeExternalObjectClass mimeExternalObjectClass"

Comment 2

[David :Bienvenu]

Comment on attachment 229263 [details] [diff] [review]
Adds an explicit linkage to "MimeExternalObjectClass mimeExternalObjectClass"

let me give this a try.

Comment 3

[David :Bienvenu]

fixed on trunk, thx for the patch. We won't need this for the 1.8.1 branch, will we?

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 229263 [details] [diff] [review]
Adds an explicit linkage to "MimeExternalObjectClass mimeExternalObjectClass"

why not just:
extern "C"  MimeExternalObjectClass mimeExternalObjectClass;

Comment 5

[Caio Tiago Oliveira (asrail)]

(In reply to comment #4)
> (From update of attachment 229263 [details] [diff] [review] [edit])
> why not just:
> extern "C"  MimeExternalObjectClass mimeExternalObjectClass;
> 

Nothing against it...

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

*** Bug 345134 has been marked as a duplicate of this bug. ***

Comment 7

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

The single-line syntax is also used at http://lxr.mozilla.org/seamonkey/source/mailnews/mime/src/mimemult.cpp#72, so I think this should be changed for consistency.

I actually think this'd be good for the branch... being able to use up-to-date compilers is kind of nice

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: 1.8 branch version

same as the "patch" attachment above, but against branch

Comment 9

[Christian :Biesinger (don't email me, ping me on IRC)]

This should be a safe change, as it affects compilation only; no runtime impact.

Comment 10

[Wolfgang Rosenauer [:wolfiR]]

*** Bug 345152 has been marked as a duplicate of this bug. ***

Comment 11

[Wolfgang Rosenauer [:wolfiR]]

Comment on attachment 229777 [details] [diff] [review]
1.8 branch version

we should have the same on 1.8.0.6 as it breaks build with new gcc

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 229777 [details] [diff] [review]
1.8 branch version

a=dbaron on behalf of drivers.  Please check in to the MOZILLA_1_8_BRANCH and mark fixed1.8.1 when you have.

Comment 13

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 229772 [details] [diff] [review]
patch

Checking in mailnews/mime/src/mimeeobj.h;
/cvsroot/mozilla/mailnews/mime/src/mimeeobj.h,v  <--  mimeeobj.h
new revision: 1.6; previous revision: 1.5
done

Comment 14

[Christian :Biesinger (don't email me, ping me on IRC)]

MOZILLA_1_8_BRANCH:

Checking in mailnews/mime/src/mimeeobj.h;
/cvsroot/mozilla/mailnews/mime/src/mimeeobj.h,v  <--  mimeeobj.h
new revision: 1.4.28.1; previous revision: 1.4
done

Comment 15

[Daniel Veditz [:dveditz]]

Comment on attachment 229777 [details] [diff] [review]
1.8 branch version

approved for 1.8.0 branch, a=dveditz for drivers

Comment 16

[Wolfgang Rosenauer [:wolfiR]]

checked in to MOZILLA_1_8_0_BRANCH