Closed
Bug 344731
Opened 19 years ago
Closed 19 years ago
Update documentation minimum versions automatically
Categories
(Bugzilla :: Documentation, enhancement)
Tracking
()
RESOLVED
FIXED
Bugzilla 3.0
People
(Reporter: cso, Assigned: cso)
References
Details
Attachments
(1 file)
4.38 KB,
patch
|
mkanat
:
review+
|
Details | Diff | Splinter Review |
People occasioanlly (usually?) change minimum versions of various perl modules, but never update them in the documentation.
Thanks to Bugzilla::Install::Requirements, the documentation can now generate the list automagically.
Assignee | ||
Comment 1•19 years ago
|
||
Updated•19 years ago
|
Severity: normal → enhancement
OS: Windows XP → All
Hardware: PC → All
Comment 2•19 years ago
|
||
Comment on attachment 229299 [details] [diff] [review]
Patch v1
Yeah, looks right to me, although I know almost nothing about Docbook.
However, you did add the <?xml> thing at the top of Bugzilla-Guide.xml--is that really a part of this bug?
Attachment #229299 -
Flags: review? → review+
Updated•19 years ago
|
Target Milestone: --- → Bugzilla 2.24
Updated•19 years ago
|
Flags: approval?
Assignee | ||
Comment 3•19 years ago
|
||
(In reply to comment #2)
> However, you did add the <?xml> thing at the top of Bugzilla-Guide.xml--is that
> really a part of this bug?
Not especially, it doesn't hurt though.
Updated•19 years ago
|
Flags: approval? → approval+
Assignee | ||
Comment 4•19 years ago
|
||
Note to self: havingp -> having in the comments.
![]() |
||
Comment 5•19 years ago
|
||
Comment on attachment 229299 [details] [diff] [review]
Patch v1
>Index: makedocs.pl
>+open(ENTITIES, '>xml/bugzilla.ent') or die('Could not open xml/bugzilla.ent: ' . $!);
I prefer the 3-arguments notation: open(ENTITIES, '>', 'xml/bugzilla.ent')
Assignee | ||
Comment 6•19 years ago
|
||
(In reply to comment #5)
> >+open(ENTITIES, '>xml/bugzilla.ent') or die('Could not open xml/bugzilla.ent: ' . $!);
>
> I prefer the 3-arguments notation: open(ENTITIES, '>', 'xml/bugzilla.ent')
The codebase is already incosnsitent on this already - although there are more with the 3 argument way.
Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v <-- makedocs.pl
new revision: 1.11; previous revision: 1.10
done
Checking in docs/xml/Bugzilla-Guide.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/Bugzilla-Guide.xml,v <-- Bugzilla-Guide.xml
new revision: 1.67; previous revision: 1.66
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•