Closed Bug 344731 Opened 18 years ago Closed 18 years ago

Update documentation minimum versions automatically

Categories

(Bugzilla :: Documentation, enhancement)

2.23
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.0

People

(Reporter: cso, Assigned: cso)

References

Details

Attachments

(1 file)

People occasioanlly (usually?) change minimum versions of various perl modules, but never update them in the documentation. 

Thanks to Bugzilla::Install::Requirements, the documentation can now generate the list automagically.
Attached patch Patch v1Splinter Review
Assignee: documentation → colin.ogilvie
Status: NEW → ASSIGNED
Attachment #229299 - Flags: review?
Severity: normal → enhancement
OS: Windows XP → All
Hardware: PC → All
Comment on attachment 229299 [details] [diff] [review]
Patch v1

Yeah, looks right to me, although I know almost nothing about Docbook.

However, you did add the <?xml> thing at the top of Bugzilla-Guide.xml--is that really a part of this bug?
Attachment #229299 - Flags: review? → review+
Target Milestone: --- → Bugzilla 2.24
Flags: approval?
(In reply to comment #2)
> However, you did add the <?xml> thing at the top of Bugzilla-Guide.xml--is that
> really a part of this bug?

Not especially, it doesn't hurt though.
Flags: approval? → approval+
Depends on: 344617
Note to self: havingp -> having in the comments.
Comment on attachment 229299 [details] [diff] [review]
Patch v1

>Index: makedocs.pl

>+open(ENTITIES, '>xml/bugzilla.ent') or die('Could not open xml/bugzilla.ent: ' . $!);

I prefer the 3-arguments notation: open(ENTITIES, '>', 'xml/bugzilla.ent')
(In reply to comment #5)
> >+open(ENTITIES, '>xml/bugzilla.ent') or die('Could not open xml/bugzilla.ent: ' . $!);
> 
> I prefer the 3-arguments notation: open(ENTITIES, '>', 'xml/bugzilla.ent')

The codebase is already incosnsitent on this already - although there are more with the 3 argument way.

Checking in docs/makedocs.pl;
/cvsroot/mozilla/webtools/bugzilla/docs/makedocs.pl,v  <--  makedocs.pl
new revision: 1.11; previous revision: 1.10
done
Checking in docs/xml/Bugzilla-Guide.xml;
/cvsroot/mozilla/webtools/bugzilla/docs/xml/Bugzilla-Guide.xml,v  <--  Bugzilla-Guide.xml
new revision: 1.67; previous revision: 1.66
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: