truncated replacement tokens in pipnss.properties

RESOLVED FIXED

Status

Mozilla Localizations
ko / Korean
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: dveditz, Assigned: channy)

Tracking

({fixed1.8.0.7, fixed1.8.1})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
in pipnss.properties the initial replacement token is mangled in the strings

  nick_template
  nick_template_with_num

Both start with "%1$\uC758", missing the 's' type specifier, which displays as a literal "%1$" (or perhaps results in an error leading to a blank string, I haven't looked at error handling in the text formatting code). Should be "%1$s\uC758" unless the \uC758 was a mistaken translation of the character s
(Assignee)

Updated

11 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

11 years ago
I confirmed this bug. But, it will be changed Firefox 2 beta 2. 
Axel, can I changed it 1.8.0 branch?

Comment 2

11 years ago
Please create a patch and request approval1.8.0.6.
(Assignee)

Comment 3

11 years ago
Created attachment 229431 [details] [diff] [review]
string changes
Attachment #229431 - Flags: approval1.8.0.6?
(Assignee)

Comment 4

11 years ago
Axel, please review this patch.

Comment 5

11 years ago
Comment on attachment 229431 [details] [diff] [review]
string changes

From a review point of view, this is fine. Please keep the approval flag open and wait with landing until we opened the development on 1.5.0.6.
Attachment #229431 - Flags: review+
(Reporter)

Comment 6

11 years ago
Comment on attachment 229431 [details] [diff] [review]
string changes

approved for 1.8.0 branch, a=dveditz for drivers
Attachment #229431 - Flags: approval1.8.0.7? → approval1.8.0.7+
(Reporter)

Comment 7

11 years ago
Needs fixing in 1.8.1 and trunk too, right?
(Assignee)

Comment 8

11 years ago
(In reply to comment #7)
> Needs fixing in 1.8.1 and trunk too, right?
> 

I did it. Thanks.
(Reporter)

Comment 9

11 years ago
Ok, on July 23, along with a bunch of other stuff. I missed it because I was looking for a reference to this bug number. Still needed on the 1.8.0 branch it looks like, right?
Keywords: fixed1.8.1
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
(Reporter)

Comment 10

11 years ago
Looks like this got checked in on Aug 23
Keywords: fixed1.8.0.7
You need to log in before you can comment on or make changes to this bug.