34485 - should show leaks in bytes when under 10000 bytes

Status: VERIFIED FIXED

(Webtools Graveyard :: Tinderbox, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think it would be good if Tinderbox showed the leak number in bytes when it is
under 10000 rather than under 1000 (as it currently does).  Leaks on the tests
are now low enough that a 15% change in the total leaks could go unnoticed on
tinderbox.

This would I think be a one character change on line:
http://lxr.mozilla.org/mozilla/source/webtools/tinderbox/showbuilds.cgi#247
where 1000 could be changed to 10000.

Alternatively, the leaks are probably now stable enough that the colors could be
brought back (although I don't think bloat is).

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I think now is a good time to do this (so we don't creep above 2K again,
although hopefully we'll get down below 2K very shortly).  I'm tired of leak
creep...

Based on a short discussion on #mozilla, I decided a "b" might be good too.  So
here's a patch.  What do you think?

Index: showbuilds.cgi
===================================================================
RCS file: /cvsroot/mozilla/webtools/tinderbox/showbuilds.cgi,v
retrieving revision 1.148
diff -u -d -r1.148 showbuilds.cgi
--- showbuilds.cgi	2000/10/25 20:14:34	1.148
+++ showbuilds.cgi	2000/10/31 01:21:54
@@ -249,18 +249,18 @@

 sub print_bloat_delta {
   my ($value, $compare) = @_;
-  my $units = ' ';
+  my $units = 'b';
   $value = $value || 0;
   $compare = $compare || 0;

   if ($value >= 1000000) {
     $value = int($value / 1000000);
     $min =   int($min / 1000000);
-    $units = 'M';
-  } elsif ($value >= 1000) {
+    $units = 'Mb';
+  } elsif ($value >= 10000) {
     $value = int($value / 1000);
     $min =   int($min / 1000);
-    $units = 'K';
+    $units = 'Kb';
   }

  # Took out colors because the numbers jump around too much. -slamm

Comment 2

[Chris McAfee]

over to me.  I agree, we should have better granularity here.

Comment 3

[Chris Waterson]

brendan scolded me about this once: there's "b"its and "B"ytes ;-).

Comment 4

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Agreed.  Fixed in my tree, but no point posting new patch.

Comment 5

[Chris McAfee]

dbaron: check in patch with b/B change, and I can push to tinderbox
to test.  r=mcafee

Comment 6

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

OK... checked in.

Comment 7

[Chris McAfee]

server updated, marking fixed.

Comment 8

[Chris McAfee]

verifying

Comment 9

[Dawn Endico]

Unsetting target milestone so we can delete the old (inappropriate)
Mozilla target milestones from Webtools.