Failure of PostCreate is not handled well

RESOLVED FIXED in mozilla1.8.1beta2

Status

()

Core
XPConnect
P1
major
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: bz, Assigned: mrbkap)

Tracking

({fixed1.8.1})

Trunk
mozilla1.8.1beta2
fixed1.8.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking1.8.1 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

We should remove the XPCWrappedNative from the map when PostCreate fails.  That way we won't get the sort of "now it doesn't work, now it does" stuff bug 344830 reports.
(Assignee)

Comment 1

11 years ago
Created attachment 229576 [details] [diff] [review]
Fix

This patch also fixes a refcounting botch introduced by the previous patch.
Assignee: dbradley → mrbkap
Status: NEW → ASSIGNED
Attachment #229576 - Flags: superreview?(brendan)
Attachment #229576 - Flags: review?(jst)
Comment on attachment 229576 [details] [diff] [review]
Fix

Sorry, I should have seen this one.

/be
Attachment #229576 - Flags: superreview?(brendan) → superreview+
Comment on attachment 229576 [details] [diff] [review]
Fix

r=jst
Attachment #229576 - Flags: review?(jst) → review+
(Assignee)

Comment 4

11 years ago
Fix checked into trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
OS: Linux → All
Priority: -- → P1
Hardware: PC → All
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.8.1beta2

Updated

11 years ago
Flags: blocking1.8.1?
Comment on attachment 229576 [details] [diff] [review]
Fix

Needed js1.7 landing followup fix.

/be
Attachment #229576 - Flags: approval1.8.1?
Comment on attachment 229576 [details] [diff] [review]
Fix

a=mconnor on behalf of drivers
Attachment #229576 - Flags: approval1.8.1? → approval1.8.1+

Updated

11 years ago
Flags: blocking1.8.1? → blocking1.8.1+
Whiteboard: [checkin needed (1.8 branch)]
(Assignee)

Comment 7

11 years ago
Fixed on the 1.8 branch.
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]

Updated

11 years ago
Depends on: 364474
You need to log in before you can comment on or make changes to this bug.