"ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: Jesse Ruderman, Assigned: longsonr)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
PowerPC
Mac OS X
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

12 years ago
###!!! ASSERTION: Don't try to move the root widget to something non-zero: 'GetParent() || (aX == 0 && aY == 0)', file /Users/admin/trunk/mozilla/view/src/nsView.cpp, line 313
(Reporter)

Comment 1

12 years ago
Created attachment 229423 [details]
testcase
(Reporter)

Updated

12 years ago
Blocks: 344905
(Assignee)

Comment 2

12 years ago
Created attachment 229518 [details] [diff] [review]
patch
Assignee: general → longsonr
Status: NEW → ASSIGNED
Attachment #229518 - Flags: review?(tor)

Comment 3

12 years ago
Comment on attachment 229518 [details] [diff] [review]
patch

>Index: nsSVGPathGeometryFrame.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/layout/svg/base/src/nsSVGPathGeometryFrame.cpp,v
>retrieving revision 1.62
>diff -u -p -8 -r1.62 nsSVGPathGeometryFrame.cpp
>--- nsSVGPathGeometryFrame.cpp	30 Jun 2006 19:19:42 -0000	1.62
>+++ nsSVGPathGeometryFrame.cpp	17 Jul 2006 19:31:05 -0000
>@@ -433,17 +433,19 @@ nsSVGPathGeometryFrame::UpdateCoveredReg
>     } else
>       cairo_fill_extents(ctx, &xmin, &ymin, &xmax, &ymax);
> 
>     cairo_user_to_device(ctx, &xmin, &ymin);
>     cairo_user_to_device(ctx, &xmax, &ymax);
> 
>     cairo_destroy(ctx);
> 
>-    mRect = nsSVGUtils::ToBoundingPixelRect(xmin, ymin, xmax, ymax);
>+    if (!IsDegeneratePath(xmin, ymin, xmax, ymax)) {
>+      mRect = nsSVGUtils::ToBoundingPixelRect(xmin, ymin, xmax, ymax);
>+    }

I think the test needs to go before the calls to cairo_user_to_device().
(Assignee)

Comment 4

12 years ago
Created attachment 229630 [details] [diff] [review]
address review comments
Attachment #229518 - Attachment is obsolete: true
Attachment #229630 - Flags: review?(tor)
Attachment #229518 - Flags: review?(tor)

Updated

12 years ago
Attachment #229630 - Flags: review?(tor) → review+
(Assignee)

Updated

12 years ago
Attachment #229630 - Flags: superreview?(roc)
Attachment #229630 - Flags: superreview?(roc) → superreview+
(Assignee)

Comment 5

12 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Reporter)

Comment 6

11 years ago
Crashtest checked in.
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.