344887 - "ASSERTION: Don't try to move the root widget to something non-zero" involving SVG opacity

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: Don't try to move the root widget to something non-zero: 'GetParent() || (aX == 0 && aY == 0)', file /Users/admin/trunk/mozilla/view/src/nsView.cpp, line 313

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Robert Longson [:longsonr]]

Attachment: patch

Comment 3

[tor]

Comment on attachment 229518 [details] [diff] [review]
patch

>Index: nsSVGPathGeometryFrame.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/layout/svg/base/src/nsSVGPathGeometryFrame.cpp,v
>retrieving revision 1.62
>diff -u -p -8 -r1.62 nsSVGPathGeometryFrame.cpp
>--- nsSVGPathGeometryFrame.cpp	30 Jun 2006 19:19:42 -0000	1.62
>+++ nsSVGPathGeometryFrame.cpp	17 Jul 2006 19:31:05 -0000
>@@ -433,17 +433,19 @@ nsSVGPathGeometryFrame::UpdateCoveredReg
>     } else
>       cairo_fill_extents(ctx, &xmin, &ymin, &xmax, &ymax);
> 
>     cairo_user_to_device(ctx, &xmin, &ymin);
>     cairo_user_to_device(ctx, &xmax, &ymax);
> 
>     cairo_destroy(ctx);
> 
>-    mRect = nsSVGUtils::ToBoundingPixelRect(xmin, ymin, xmax, ymax);
>+    if (!IsDegeneratePath(xmin, ymin, xmax, ymax)) {
>+      mRect = nsSVGUtils::ToBoundingPixelRect(xmin, ymin, xmax, ymax);
>+    }

I think the test needs to go before the calls to cairo_user_to_device().

Comment 4

[Robert Longson [:longsonr]]

Attachment: address review comments

Comment 5

[Robert Longson [:longsonr]]

Checked in.

Comment 6

[Jesse Ruderman]

Crashtest checked in.