34499 - Block Image from Loading should appear inactive when over blocked images

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[sairuh (rarely reading bugmail)]

split off from bug 34165.

to repro:
1. go to the above URL.
2. over the banner at the top of the page, bring up the context menu.
3. from the context menu, select Block Image from Loading.
4. reload the page. note that banner's no longer there (black box instead),
which is expected.
5. bring up context menu over banner area.

results: observe that Block Image from Loading appears active in the context
menu, ie, not greyed out.

expected: if an image is blocked (not loaded), the context menu should recognize
that and not have the Block Image from Loading item active.

Comment 1

[Stephen P. Morse]

Fixed.  Rather than make the "Block Image" entry inactive (i.e., grayed out) if 
the image is already blocked, I simply removed the entry.

Comment 2

[sairuh (rarely reading bugmail)]

will verify this once bug 33079 is fixed.

Comment 3

[sairuh (rarely reading bugmail)]

verif on linux, winNT and macOS using opt comm bits 2000.04.13.10/09-m16.

when an image is blocked, the context menu item "Block Image from Loading" is no
longer listed. (note that you still need to reload the page to observe the
missing image, o'course. :-)