345026 - Iframe content goes away while new page is loading

Status: REOPENED

(Core :: DOM: Navigation, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.

To reproduce:
Disable bfcache by setting browser.sessionhistory.max_total_viewers to 0 in about:config
Then click on the link to slow loading site

Result:
The frame contentdisappears just before the new page is loaded, 
while the rest of the page content is still there for a split second. 

Expected result:
The frame content should disappear at the same time as the rest of the page content. 
With bfcache on, you don't see the bug and you get to see the expected result.

This is not a recent regression, I can see the bug even with Mozilla1.7.12.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Ah, I see what's going on here.  nsDocument::Destroy unbinds the iframe, which kills the docshell inside it, but doesn't tear down the outer document presentation...  This probably depends on subshells surviving unbind, and maybe on nuking nsDocument::Destroy (both already covered by bugs).  :(

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This should be fixed on trunk with the patch from bug 348156

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Reopened since bug 348156 was backed out.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Can we get a regression test in for this, by the way?

Comment 6

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Hmm.. so this wasn't actually fixed by the patch in bug 348156. We still kill the inner docshell since docshells aren't part of cycle collection :(

So I guess this one is blocked by getting docshells added to cyclecollection.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, so the assignee is being reset.