Closed Bug 345079 Opened 16 years ago Closed 14 years ago

nsSetDefaultBrowser.js is not installed by make install

Categories

(Firefox Build System :: General, defect)

1.8 Branch
x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Well, everything is in the summary... patch following. I still don't get how things like this can happen. And it's not the first time I report such issues. People who write the Makefile.in files should know better the build system...
Patch against firefox 2.0b1 source
Attachment #229690 - Flags: review?(benjamin)
Mike, you're probably the only person who uses "make install"... I'm pretty sure even redhat uses "make -C browser/installer" and unpacks the resulting tarball to install the browser, and that's what I'd like "make install" to do in the future.
All mozilla based packages in debian and ubuntu use make install.
All standard applications for unix provide a working make install rule.
And make -C browser/installer doesn't install everything (think pkgconfig files, headers, idl files, etc).
Plus, there are a lot of helpers around to install component files, to install chrome files, and such. Why not use it instead of re-inventing the wheel in every Makefile.in ?
Attachment #229690 - Flags: review?(benjamin) → review+
Mike, is this a problem on the trunk, or does it just affect the 2.0 branch?
Assignee: nobody → mh+mozilla
This has been fixed by bug #386477
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
When something is fixed by another bug, we say that the other bugs are now "WORKSFORME". We only use FIXED when the bug actually did something to fix an issue. It's strange, but it's the usual way for some reason.
Resolution: FIXED → WORKSFORME
This was fixed by bug 386477....
Resolution: WORKSFORME → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.