345079 - nsSetDefaultBrowser.js is not installed by make install

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Well, everything is in the summary... patch following. I still don't get how things like this can happen. And it's not the first time I report such issues. People who write the Makefile.in files should know better the build system...

Comment 1

[Mike Hommey [:glandium]]

Attachment: Patch for the issue

Patch against firefox 2.0b1 source

Comment 2

[Benjamin Smedberg]

Mike, you're probably the only person who uses "make install"... I'm pretty sure even redhat uses "make -C browser/installer" and unpacks the resulting tarball to install the browser, and that's what I'd like "make install" to do in the future.

Comment 3

[Mike Hommey [:glandium]]

All mozilla based packages in debian and ubuntu use make install.
All standard applications for unix provide a working make install rule.
And make -C browser/installer doesn't install everything (think pkgconfig files, headers, idl files, etc).
Plus, there are a lot of helpers around to install component files, to install chrome files, and such. Why not use it instead of re-inventing the wheel in every Makefile.in ?

Comment 4

[Reed Loden [:reed]]

Mike, is this a problem on the trunk, or does it just affect the 2.0 branch?

Comment 5

[Mike Hommey [:glandium]]

This has been fixed by bug #386477

Comment 6

[Reed Loden [:reed]]

When something is fixed by another bug, we say that the other bugs are now "WORKSFORME". We only use FIXED when the bug actually did something to fix an issue. It's strange, but it's the usual way for some reason.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

This was fixed by bug 386477....