Closed Bug 345127 Opened 18 years ago Closed 18 years ago

nsSearchService's loadListener should implement nsIBadCertListener to avoid popping up "wrong cert" dialogs

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2 beta2

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Keywords: fixed1.8.1, Whiteboard: [mustfix])

Attachments

(1 file)

patch
2.01 KB, patch
mconnor
: review+
mtschrep
: approval1.8.1+
Details | Diff | Splinter Review 
This will be more important once the search engine update system lands (bug 327932).
Attached patch patch — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #229746 -
        Flags: review?(mconnor)
Flags: blocking-firefox2?
Whiteboard: [patch-r?]
Target Milestone: --- → Firefox 2 beta2
Flags: blocking-firefox2? → blocking-firefox2+

    
    

    
  
Note: I'm implementing a similar fix over in bug 344277, and it's causing a crash which dbaron thinks is bug 335018.

    
    

    
  
Comment on attachment 229746 [details] [diff] [review]
patch

Please note myk's comment about the crash on branch, and the bug causing it.

        Attachment #229746 -
        Flags: review?(mconnor) → review+
Whiteboard: [patch-r?] → [checkin needed]

    
    

    
  
mozilla/browser/components/search/nsSearchService.js 	1.62
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed] → [need-a]

    
    

    
  
Comment on attachment 229746 [details] [diff] [review]
patch

I've tested this on the branch and haven't seen the crash Myk mentions - perhaps this is due to this patch not implementing nsIAuthPrompt. This has been on the trunk since Monday night.

        Attachment #229746 -
        Flags: approval1.8.1?
Whiteboard: [need-a] → [mustfix][has patch][needs approval]

    
  

        Attachment #229746 -
        Flags: approval1.8.1? → approval1.8.1+
Whiteboard: [mustfix][has patch][needs approval] → [checkin needed (1.8 branch)][mustfix]

    
    

    
  
mozilla/browser/components/search/nsSearchService.js 	1.1.2.53
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)][mustfix] → [mustfix]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: