345157 - RLk:-2147482512.00000B on balsa mozilla1.8 leak test

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Robert Helmer [:rhelmer]]

As of the build started 07/17 14:22, finished 07/17 14:59, the refcnt leak number for balsa on the mozilla1.8 tree has been -2147482512.00000B

This seems to be because of this line:
   399 nsLayoutStatics                                 1 -2147483648        0       -2 (    0.00 +/-     0.00)       58       -1 (   25.48 +/-    13.74)

The closest match in the checkins for this build seems to be for bug 331117, which touches mozilla/layout/build/nsLayoutStatics.cpp

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible trunk patch

LogCtor and LogDtor are for *non-refcounted* objects.  You're not supposed to use both refcount logging and ctor/dtor logging.  That *might* fix this problem, although I haven't checked.  However, it's probably at the very least going to make debugging it easier.  I also made the size consistently reported as 1, since 0 could confuse some things.

The problem hasn't been observed on the trunk, but I'd like to get this in to both trunk and branch.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: possible 1.8 branch patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk.

Comment 4

[Darin Fisher]

Comment on attachment 230006 [details] [diff] [review]
possible 1.8 branch patch

a=darin on behalf of drivers

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to MOZILLA_1_8_BRANCH.

Comment 6

[Reed Loden [:reed]]

Is there a reason why this bug isn't RESO FIXED and keyword fixed1.8.1?

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This did fix the problem, so no need for further investigation.