345348 - Tasks appear in calendar view when progress is modified

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[George Privon]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.0.4) Gecko/20060614 Fedora/1.5.0.4-1.2.fc5 Firefox/1.5.0.4 pango-text
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060720 Calendar/0.3a2+

"Tasks in View" is disabled.

However, when I modify the progress of a task, the task appears in the calendar view, even though I have "Tasks in View" disabled. If I exit calendar and reload, the task is no longer displayed in the calendar view.

Reproducible: Always

Steps to Reproduce:
1. Disable "View -> Tasks in View"
2. Create a task
3. Modify the progress by right-clicking on the task.

Actual Results:  
The task appeared in the week view and the progress was changed in the task list.

Expected Results:  
Changed the progress in the task list.

Comment 1

[Joey Minta]

Yeah, need to add a check for this in the view's observers.

Comment 2

[Joey Minta]

Attachment: also check for mTasksInView

We should also check mTasksInView to filter out tasks in the observer when we're not showing them.

Comment 3

[Joey Minta]

Comment on attachment 230392 [details] [diff] [review]
also check for mTasksInView

r=dmose

Comment 4

[Joey Minta]

patch checked in.

Comment 5

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060802 Calendar/0.3a2+:

Problem still exist with Multiweek/Month view.

Comment 6

[Joey Minta]

Attachment: more checks

Same patch for the month view.  Really, at this point, we should come up with a common set of add/remove item functions and share this observer between the views.  But that's another bug.

Comment 7

[Joey Minta]

Comment on attachment 231785 [details] [diff] [review]
more checks

r=dmose

Comment 8

[Joey Minta]

'more checks' patch checked in.