Closed Bug 345404 Opened 13 years ago Closed 13 years ago

"engine has no interval" error at startup, search doesn't work

Categories

(Firefox :: Search, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: Gavin, Assigned: Gavin)

References

Details

Attachments

(1 file)

The patch for bug 327932 had a bug - the search service will fail to load if an engine doesn't have an update interval specified.
Attached patch patchSplinter Review
I thought that _updateInterval was set unconditionally in the _parseAs functions, but it's only set in _parseAsOpenSearch if the engine description file has an UpdateInterval element, which leads to the error. This moves the fallback back into _scheduleNextUpdate and handles engines with no specified interval. Also, this makes sure we don't save update-specific information if the engine has no update URLs (which could potentially slow down startup), so that we don't even get into this situation if the engine doesn't have an update URL.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #230059 - Flags: review?(jminta)
Comment on attachment 230059 [details] [diff] [review]
patch

looks good to me. r=jminta
Attachment #230059 - Flags: review?(jminta) → review+
mozilla/browser/components/search/nsSearchService.js 	1.57
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I'll roll this into the branch patch for bug 327932.
You need to log in before you can comment on or make changes to this bug.