345404 - "engine has no interval" error at startup, search doesn't work

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

The patch for bug 327932 had a bug - the search service will fail to load if an engine doesn't have an update interval specified.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I thought that _updateInterval was set unconditionally in the _parseAs functions, but it's only set in _parseAsOpenSearch if the engine description file has an UpdateInterval element, which leads to the error. This moves the fallback back into _scheduleNextUpdate and handles engines with no specified interval. Also, this makes sure we don't save update-specific information if the engine has no update URLs (which could potentially slow down startup), so that we don't even get into this situation if the engine doesn't have an update URL.

Comment 2

[Joey Minta]

Comment on attachment 230059 [details] [diff] [review]
patch

looks good to me. r=jminta

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.57

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I'll roll this into the branch patch for bug 327932.