345418 - ASSERTION: trying to construct an SVGTSpanFrame for an invalid container

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Jesse Ruderman]

###!!! ASSERTION: trying to construct an SVGTSpanFrame for an invalid container: 'Error', file /Users/admin/trunk/mozilla/layout/svg/base/src/nsSVGTSpanFrame.cpp, line 57

And similar assertions:
http://lxr.mozilla.org/seamonkey/search?string=invalid+container

I think these are just bogus assertions.

Comment 1

[Jesse Ruderman]

Attachment: testcase

Comment 2

[Robert Longson [:longsonr]]

Should write to the Error Console instead.

Comment 3

[Robert Longson [:longsonr]]

Attachment: convert assert to warning in Error Console

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 231091 [details] [diff] [review]
convert assert to warning in Error Console

IMHO this check should remain an assertion and code should be added to nsCSSFrameConstructor to prevent this being reached. nsCSSFrameConstructor is the place where we detect and handle invalid DOMs.

Comment 5

[Robert Longson [:longsonr]]

Attachment: check tspan and textPath parents

I've not put in any console logging. There isn't any currently in nsCSSFrameConstructor but it wouldn't be too difficult to write a static ReportInvalidParent method, though I'm not sure which properties file to use. Presumably various html elements could have an invalid parent also.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

+    if (aParentFrame->IsFrameOfType(nsIFrame::eSVG)) {

Why bother with this check?

Otherwise, looks great.

Comment 7

[Robert Longson [:longsonr]]

Attachment: address review comment

Comment 8

[Robert Longson [:longsonr]]

checked in

Comment 9

[Jesse Ruderman]

Crashtest checked in.