Last Comment Bug 345419 - "Use as Dock Menu" menu item for the current dock menu folder should reset Dock Menu to default folder
: "Use as Dock Menu" menu item for the current dock menu folder should reset Do...
Status: RESOLVED FIXED
[Good First Bug]
: fixed1.8.1.1
Product: Camino Graveyard
Classification: Graveyard
Component: Bookmarks (show other bugs)
: 1.8 Branch
: PowerPC Mac OS X
-- trivial (vote)
: ---
Assigned To: froodian (Ian Leue)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2006-07-20 23:09 PDT by Stuart Morgan
Modified: 2006-12-08 09:05 PST (History)
2 users (show)
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch (3.13 KB, patch)
2006-11-08 15:19 PST, froodian (Ian Leue)
no flags Details | Diff | Splinter Review
Patch (4.06 KB, patch)
2006-11-08 16:01 PST, froodian (Ian Leue)
no flags Details | Diff | Splinter Review
Patch (5.20 KB, patch)
2006-11-13 00:11 PST, froodian (Ian Leue)
stuart.morgan+bugzilla: review-
Details | Diff | Splinter Review
Not on Crack (6.17 KB, patch)
2006-11-28 12:30 PST, froodian (Ian Leue)
bugzilla-graveyard: review+
mikepinkerton: superreview+
Details | Diff | Splinter Review

Description User image Stuart Morgan 2006-07-20 23:09:58 PDT
Having the current dock menu folder show a "Use as Dock Menu" option is confusing, and isn't useful. It either shouldn't show up at all, or it should be replaced with a "Stop using as Dock Menu" item (once bug 244116 lands).

This will probably require either checking against the dockMenuFolder, or changes to make sure the fallback case always sets the flag on the fallback, in order to do the right thing after a user has unset the dock menu.
Comment 1 User image froodian (Ian Leue) 2006-11-08 14:51:53 PST
Per IRC, since we now check this menu item for the current dock folder, selecting it should set the folder back to default.
Comment 2 User image froodian (Ian Leue) 2006-11-08 15:19:30 PST
Created attachment 245040 [details] [diff] [review]
Patch
Comment 3 User image froodian (Ian Leue) 2006-11-08 16:01:58 PST
Created attachment 245043 [details] [diff] [review]
Patch

Oops, forgot the context menu for collections.
Comment 4 User image Stuart Morgan 2006-11-12 16:34:07 PST
Comment on attachment 245043 [details] [diff] [review]
Patch

>+-(void) toggleDockMenu:(id)sender;

toggleIsDockMenu:

> - (IBAction) setAsDockMenuFolder:(id)aSender

toggleIsDockMenuFolder:

Can you respin this against the current trunk (sorry, I forgot there was an outstanding patch against bookmark code when I did that), with these changes?
Comment 5 User image froodian (Ian Leue) 2006-11-13 00:11:41 PST
Created attachment 245440 [details] [diff] [review]
Patch
Comment 6 User image Stuart Morgan 2006-11-15 22:13:23 PST
Comment on attachment 245440 [details] [diff] [review]
Patch

This broke Use as Dock Menu on the collections in the bookmark manager; they are always disabled after I apply the patch.
Comment 7 User image froodian (Ian Leue) 2006-11-28 12:30:46 PST
Created attachment 246827 [details] [diff] [review]
Not on Crack

Oops, yeah.
Comment 8 User image Chris Lawson (gone) 2006-12-06 19:46:32 PST
Comment on attachment 246827 [details] [diff] [review]
Not on Crack

r=me on this. I've been playing around with this code a bunch tonight and this looks good.
Comment 9 User image Mike Pinkerton (not reading bugmail) 2006-12-08 05:33:25 PST
Comment on attachment 246827 [details] [diff] [review]
Not on Crack

sr=pink
Comment 10 User image froodian (Ian Leue) 2006-12-08 09:05:53 PST
Checked in on 1.8branch and trunk.

Note You need to log in before you can comment on or make changes to this bug.