The default bug view has changed. See this FAQ.

"Use as Dock Menu" menu item for the current dock menu folder should reset Dock Menu to default folder

RESOLVED FIXED

Status

Camino Graveyard
Bookmarks
--
trivial
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: Stuart Morgan, Assigned: froodian (Ian Leue))

Tracking

({fixed1.8.1.1})

1.8 Branch
PowerPC
Mac OS X
fixed1.8.1.1

Details

(Whiteboard: [Good First Bug])

Attachments

(1 attachment, 3 obsolete attachments)

6.17 KB, patch
Chris Lawson (gone)
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

11 years ago
Having the current dock menu folder show a "Use as Dock Menu" option is confusing, and isn't useful. It either shouldn't show up at all, or it should be replaced with a "Stop using as Dock Menu" item (once bug 244116 lands).

This will probably require either checking against the dockMenuFolder, or changes to make sure the fallback case always sets the flag on the fallback, in order to do the right thing after a user has unset the dock menu.
(Assignee)

Comment 1

11 years ago
Per IRC, since we now check this menu item for the current dock folder, selecting it should set the folder back to default.
Summary: "Use as Dock Menu" shouldn't show up in the context menu for the current dock menu folder → "Use as Dock Menu" menu item for the current dock menu folder should reset Dock Menu to default folder
(Assignee)

Updated

11 years ago
Whiteboard: [Good First Bug]
(Assignee)

Comment 2

11 years ago
Created attachment 245040 [details] [diff] [review]
Patch
Assignee: nobody → stridey
Status: NEW → ASSIGNED
Attachment #245040 - Flags: review?(stuart.morgan)
(Assignee)

Comment 3

11 years ago
Created attachment 245043 [details] [diff] [review]
Patch

Oops, forgot the context menu for collections.
Attachment #245040 - Attachment is obsolete: true
Attachment #245043 - Flags: review?(stuart.morgan)
Attachment #245040 - Flags: review?(stuart.morgan)
(Reporter)

Comment 4

11 years ago
Comment on attachment 245043 [details] [diff] [review]
Patch

>+-(void) toggleDockMenu:(id)sender;

toggleIsDockMenu:

> - (IBAction) setAsDockMenuFolder:(id)aSender

toggleIsDockMenuFolder:

Can you respin this against the current trunk (sorry, I forgot there was an outstanding patch against bookmark code when I did that), with these changes?
Attachment #245043 - Flags: review?(stuart.morgan)
(Assignee)

Comment 5

11 years ago
Created attachment 245440 [details] [diff] [review]
Patch
Attachment #245043 - Attachment is obsolete: true
Attachment #245440 - Flags: review?(stuart.morgan)
(Reporter)

Comment 6

11 years ago
Comment on attachment 245440 [details] [diff] [review]
Patch

This broke Use as Dock Menu on the collections in the bookmark manager; they are always disabled after I apply the patch.
Attachment #245440 - Flags: review?(stuart.morgan) → review-
(Assignee)

Comment 7

11 years ago
Created attachment 246827 [details] [diff] [review]
Not on Crack

Oops, yeah.
Attachment #245440 - Attachment is obsolete: true
Attachment #246827 - Flags: review?(stuart.morgan)

Comment 8

10 years ago
Comment on attachment 246827 [details] [diff] [review]
Not on Crack

r=me on this. I've been playing around with this code a bunch tonight and this looks good.
Attachment #246827 - Flags: review?(stuart.morgan) → review+

Updated

10 years ago
Attachment #246827 - Flags: superreview?(mikepinkerton)
Comment on attachment 246827 [details] [diff] [review]
Not on Crack

sr=pink
Attachment #246827 - Flags: superreview?(mikepinkerton) → superreview+
(Assignee)

Comment 10

10 years ago
Checked in on 1.8branch and trunk.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: fixed1.8.1.1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.