345419 - "Use as Dock Menu" menu item for the current dock menu folder should reset Dock Menu to default folder

Status: RESOLVED FIXED

(Camino Graveyard :: Bookmarks, defect)

Description

[Stuart Morgan]

Having the current dock menu folder show a "Use as Dock Menu" option is confusing, and isn't useful. It either shouldn't show up at all, or it should be replaced with a "Stop using as Dock Menu" item (once bug 244116 lands).

This will probably require either checking against the dockMenuFolder, or changes to make sure the fallback case always sets the flag on the fallback, in order to do the right thing after a user has unset the dock menu.

Comment 1

[froodian (Ian Leue)]

Per IRC, since we now check this menu item for the current dock folder, selecting it should set the folder back to default.

Comment 2

[froodian (Ian Leue)]

Attachment: Patch

Comment 3

[froodian (Ian Leue)]

Attachment: Patch

Oops, forgot the context menu for collections.

Comment 4

[Stuart Morgan]

Comment on attachment 245043 [details] [diff] [review]
Patch

>+-(void) toggleDockMenu:(id)sender;

toggleIsDockMenu:

> - (IBAction) setAsDockMenuFolder:(id)aSender

toggleIsDockMenuFolder:

Can you respin this against the current trunk (sorry, I forgot there was an outstanding patch against bookmark code when I did that), with these changes?

Comment 5

[froodian (Ian Leue)]

Attachment: Patch

Comment 6

[Stuart Morgan]

Comment on attachment 245440 [details] [diff] [review]
Patch

This broke Use as Dock Menu on the collections in the bookmark manager; they are always disabled after I apply the patch.

Comment 7

[froodian (Ian Leue)]

Attachment: Not on Crack

Oops, yeah.

Comment 8

[Chris Lawson (gone)]

Comment on attachment 246827 [details] [diff] [review]
Not on Crack

r=me on this. I've been playing around with this code a bunch tonight and this looks good.

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 246827 [details] [diff] [review]
Not on Crack

sr=pink

Comment 10

[froodian (Ian Leue)]

Checked in on 1.8branch and trunk.